Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
afdb8c7 to
6911c2c
Compare
khatwanimohit
approved these changes
Feb 21, 2026
6911c2c to
2d43a9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the MoE compute block by merging the two gating GMM kernels ($W_0$ and $W_1$ ) into a single, unified matrix multiplication pass.
Motivation$W_0$ and $W_1$ effectively gives us a 2X increase in that local dimension, restoring arithmetic intensity and hardware utilization.
In the previous SwiGLU/GLU implementation, the gate-projection and up-projection were processed using two sequential
gmm_fncalls. By concatenating these weights and processing them together, we effectively double the contiguous hidden dimension of the kernel. This is especially critical for FP8 utilizing Expert Parallelism (EP) that shard along the contracting dimension. Because this sharding strategy inherently shrinks the local MLP hidden dimension on each device, the matrix multiplications can become small and bottlenecked by memory bandwidth. MergingExpected Impact
Performance: Increased forward and backward pass throughput for the MoE layers, particularly on EP setups sharded along the contracting dimension due to the 2X larger local GMM sizes.
Tests
The operation is mathematically equivalent to the previous implementation. The quality has been verified through convergence test.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.