feat: add pretrained orbax cache for fast WAN inference loads#406
Draft
csgoogle wants to merge 1 commit into
Draft
feat: add pretrained orbax cache for fast WAN inference loads#406csgoogle wants to merge 1 commit into
csgoogle wants to merge 1 commit into
Conversation
Perseus14
reviewed
May 16, 2026
Collaborator
Perseus14
left a comment
Perseus14
left a comment
There was a problem hiding this comment.
Can you also add this for the other WAN models?
Comment on lines
+92
to
+93
| def _get_pretrained_orbax_dir(self) -> str: | ||
| return getattr(self.config, "pretrained_orbax_dir", "") |
Collaborator
There was a problem hiding this comment.
Do we need this function? We could just directly use getattr(self.config, "pretrained_orbax_dir", "") as it is only needed in one place. Also should the default value be None instead of ""
Comment on lines
+92
to
+93
| def _get_pretrained_orbax_dir(self) -> str: | ||
| return getattr(self.config, "pretrained_orbax_dir", "") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.