Fix fetching the correct sort field for relations#548
Open
kskaiser wants to merge 1 commit into
Open
Conversation
Having a relation defined in discovery.xml including a sort configuration, the Solr query might fail and no results are provided. This happens, if the metadata field used for sorting is a multi-valued field. Instead of adding the plain metadata field, the field type must be considered to get the correct Solr field. fixes 4Science#547 Signed-off-by: Katharina Kaiser <katharina.kaiser@tuwien.ac.at>
Author
|
@AdamF42 can you please take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Having a relation defined in discovery.xml including a sort configuration, the Solr query might fail and no results are provided. This happens, if the metadata field used for sorting is a multi-valued field (e.g., "dc.date.issued").
Instead of adding the plain metadata field, the field type must be considered to get the correct Solr field used for sorting.
References
Instructions for Reviewers
In discovery.xml in bean "relationAuthorResearchOutputsConfiguration" in the "searchSortConfiguration" set the defaultSortField to "sortDateIssuedDesc", add this sortfield also to the list of sortFields
Then load a researcher profile with the publications. There will not be any results; the layout of the page seems to be of DSpace Core.
List of changes in this PR:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.