Skip to content

use authority instead of value for type-bind#355

Open
philippcle wants to merge 2 commits into4Science:dspace-cris-7from
philippcle:patch-2
Open

use authority instead of value for type-bind#355
philippcle wants to merge 2 commits into4Science:dspace-cris-7from
philippcle:patch-2

Conversation

@philippcle
Copy link

In the current version of DSpace-CRIS-7, it is not possible to store values in MD fields that are associated with type-bind. This is because the validate method in MetadataValidator.java uses the value of DocumentType, but in DSpace-CRIS-7 the DocumentType is controlled by the controlled-vocabulary publication-coar-types. Therefore, the validate method must use the authority of the DocumentType.

@saschaszott
Copy link

This issue affects at least DS CRIS 2023.01 and 2022.03.

@philippcle
Copy link
Author

philippcle commented Jul 13, 2023

The issue that empty MD fields with the required-property are accepted when these fields are associated with a type-bind is also fixed by this PR.

@philippcle
Copy link
Author

It is important to point out that the problem only occurs if you have implemented the type bind using the COAR vocabulary.

@github-actions
Copy link

github-actions bot commented Mar 8, 2026

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Mar 8, 2026
@saschaszott
Copy link

Has the problem been fixed in the meantime?

@github-actions github-actions bot removed the stale label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants