Conversation
Spring 4 followed Tomcat 11's lead and dropped the max parts count parameter down to 10 from 50. Unfortunately, AEM form submissions contain more than 10 parts, so the default no longer suffices. Rather than require every application to set server.tomcat.max-part-count in their application.properties we will auto-configure the setting if it is too low.
Updated main Spring Boot Autoconfigure to not load when RestClientSsl is not available. This will allow the Jersey starter to work without the spring-boot-restclient-starter in the classpath.
Spring 4 has the latest version and we'll let Spring manage this from here on out.
Also, start using WireMock/Spring Boot integration. This will allow for random ports to be used in that test. Fixed an issue that surfaced during testing. New version of WireMock/Spring Integration uses new version of Apache HTTP client that does not like duplicate headers. The POST proxy code was generating duplicate Transfer-Encoding headers, so had to implement code to remove the duplicate.
Altered the tests to use the Spring/WireMock integration which allows for the use of random ports instead of fixed ports. New libraries surfaced an issue with the server code returning duplicate Transfer-Encoding headers in POST responses. This was corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Spring Boot 4
Update WireMock tests to use latest version of WireMock
Update WireMock tests that don't use Spring Boot integration to do so (so that ports are randomized)
Fix issues where AemProxy code was returning duplicate Transfer-Encoding headers