add quote of the day #4059
Open
add quote of the day #4059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
previously approved these changes
Apr 11, 2025
Contributor
|
@akostadinov I added some backend: akostadinov#2 Now the quote is only shown when the Also, we can add new quotes to the locale file, and it will randomly take one. At the end I couldn't add the George Takei quote because I think it makes no sense without a link to the original toot. And it's not safe to let the React component eval HTML inline in quotes, IMO. |
Write some backend for the quotes
jlledom
approved these changes
Jun 4, 2025
|
This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days. |
|
This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding quote of the day to login page. I was not sure which place is better so I added it under the login form as well under Red Hat logo.
Let me know if I should it to any additional places for better visibility.