extended api tests #162
Merged
extended api tests #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkudlej
requested changes
Oct 7, 2024
Gituser010
changed the title
Gituser010
changed the title
Gituser010
changed the title
mkudlej
requested changes
Oct 14, 2024
Collaborator
mkudlej
left a comment
mkudlej
left a comment
There was a problem hiding this comment.
for all changes do pipenv run python -m pylint tests/integration/conftest.py tests/integration/test_integration_account_plans.py tests/integration/test_integration_accounts.py tests/integration/test_integration_activedocs.py tests/integration/test_integration_application_plan.py threescale_api/client.py threescale_api/resources.py --disable="C0115,C0116" and fix lines where you did changes. Do the same for flake8.
GET /admin/api/application_plans
Gituser010
changed the title
Gituser010
force-pushed
the
master
branch
3 times, most recently
from
1c6564a to
218bf6b
Compare
mkudlej
requested changes
Nov 25, 2024
Collaborator
mkudlej
left a comment
mkudlej
left a comment
There was a problem hiding this comment.
It seems to me OK except of some small problems, please fix them.
mkudlej
requested changes
Dec 11, 2024
dhlavac
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /admin/api/application_plans