Move XSD manifest retrieval into dedicated SlnxXsdProvider class with interface#36
Merged
304NotModified merged 3 commits intomainfrom Mar 12, 2026
Merged
Conversation
Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor manifest retrieval into separate class
Move XSD manifest retrieval into dedicated SlnxXsdProvider class
Mar 11, 2026
Owner
|
@copilot create also an interface and use that one |
…stration Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Move XSD manifest retrieval into dedicated SlnxXsdProvider class
Move XSD manifest retrieval into dedicated SlnxXsdProvider class with interface
Mar 12, 2026
a4651c1 to
e08b310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XsdValidatorwas directly responsible for both locating the embedded XSD resource and performing validation — mixing resource lookup with validation logic.Changes
ISlnxXsdProvider— interface defining theGetXsdStream()contractSlnxXsdProvider— implementsISlnxXsdProvider; extracts theconst XsdResourceNameandGetXsdStream()(wrappingAssembly.GetManifestResourceStream) into its own classXsdValidator— now acceptsISlnxXsdProvideras a constructor dependency; delegates resource loading entirely to itISlnxXsdProviderregistered as singleton mapping toSlnxXsdProviderinServiceCollectionExtensionsnew SlnxXsdProvider()when constructingXsdValidatordirectly✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.