fix: Fix issue where editing source text during website redirection r…#8046
fix: Fix issue where editing source text during website redirection r…#8046f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
…esults in an error
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| absolutePath := path.Join(GetSitePath(website, SiteRedirectDir), req.Name+".conf") | ||
| fileOp := files.NewFileOp() | ||
| oldRewriteContent, err = fileOp.GetContent(absolutePath) | ||
| if err != nil { |
There was a problem hiding this comment.
There do not appear to be any significant issues with this code. Please ensure that you have updated all dependencies and packages since the last run.
Additionally, consider implementing a more robust error handling strategy within your function calls such as using return points inside functions when something goes wrong instead of returning falsey values like nil, which is often left undefined and can cause confusion. This approach will make your code clearer and easier to understand.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
No description provided.