This repository was archived by the owner on Jun 27, 2018. It is now read-only.
Make tool_consumer_instance_guid optional#47
Open
mdjnelson wants to merge 1 commit into1EdTech:masterfrom
mdjnelson:optional-tool_consumer_instance_guid
Open
Make tool_consumer_instance_guid optional#47mdjnelson wants to merge 1 commit into1EdTech:masterfrom mdjnelson:optional-tool_consumer_instance_guid
mdjnelson wants to merge 1 commit into1EdTech:masterfrom
mdjnelson:optional-tool_consumer_instance_guid
Conversation
In the specification, tool_consumer_instance_guid is only listed as recommended. https://www.imsglobal.org/specs/ltiv2p0/implementation-guide#toc-42 - however the library was requiring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the specification, tool_consumer_instance_guid is only listed as recommended. https://www.imsglobal.org/specs/ltiv2p0/implementation-guide#toc-42 - however the library was requiring it.