Define consumer profile member variable for ToolConsumer#10
Define consumer profile member variable for ToolConsumer#10junpataleta wants to merge 1 commit into1EdTech:masterfrom junpataleta:issue-009
Conversation
|
Thanks for the request, but I am not sure I follow the reasoning behind it. A Tool Profile is associated with a Tool Provider, so why should this be added as a property of the ToolConsmer object? How would you intend to use this? Do we need to extend the data model to store it? Thanks. |
|
Hi Stephen, The Furthermore, there are various instances in the library where it is being accessed (e.g. in DataConnector_mysql.php). So I assume that this needs to be declared as a public variable. |
|
Sorry, I totally misunderstood the profile variable as a ToolProfile object and realised that it refers to the tool consumer profile data. Which is basically a generic object type. I have updated the patch with the correct definition in the PHPDoc. |
|
Yeah, this looks fine. 👍 |
Fix for #9