Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Conversation

@buckley-w-david
Copy link
Contributor

As per #783, this PR proposes a replacement to the current CLI, with the interface outlined therein, with a change that the command is pulse instead of data.

buckley-w-david and others added 3 commits April 25, 2018 13:50
initial modularization refactor of the data update process
replace existing CLI interface with new consolidated, click-based CLI
@konklone
Copy link
Contributor

@buckley-w-david Thanks for your patience - I just resolved the slight merge conflict from the couple PRs that got merged before this. I'll review this shortly.

Also, are you up for joining a Slack channel 18F/TTS runs, with a few other relevant folks, about this work? If so, do you want to send a quick email to eric.mill@gsa.gov to share your work email with me?

@buckley-w-david
Copy link
Contributor Author

buckley-w-david commented Apr 30, 2018

Sounds good, I sent you an email.

I urge caution on actually merging in this change, it's fairly large and interfaces with large untested portions of the code, so we should be quite careful with it.

The tests included strictly only test the CLI itself

@konklone
Copy link
Contributor

Yeah, that's part of the delay -- it needs some dedicated human testing.

@buckley-w-david buckley-w-david deleted the 18F_CLI branch May 7, 2018 16:15
@buckley-w-david buckley-w-david restored the 18F_CLI branch May 7, 2018 16:15
@buckley-w-david
Copy link
Contributor Author

Do not remember closing this one, re-opening in case the features are still wanted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants