Skip to content

Conversation

@ChanHongMing
Copy link

Description

Fixing the method handler crash issue when calling eth_simulateV1 method.

Changes

Bugfix (non-breaking change that solves an issue)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

issue of the eth_simulateV1 is casued by BlobScheduleConfig being nil during calling to CalcBlobFee on Bor chains. After resolving this issue. Calling eth_simulateV1 result in "unexpected withdrawals" error, which indicate withdrawals are not supported in the block body. Then, this issue is resolved by setting it to Nil for bor chain. Finally, functions SetStateSync and SubscribeStateSyncEvent are added to simChainHeadReader so that it implements core.BorStateSyncer

@ChanHongMing ChanHongMing changed the title V2.5.6 candidate fix(rpc): eth_simulateV1 method handler crash Dec 23, 2025
@Raneet10 Raneet10 requested a review from a team December 26, 2025 09:43
@kamuikatsurgi
Copy link
Member

Hey @ChanHongMing, I think one or few unit tests are failing, could you check and fix them?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ChanHongMing
Copy link
Author

Hello @kamuikatsurgi I have fixed the unit test and it is now working.

@kamuikatsurgi
Copy link
Member

Hello @kamuikatsurgi I have fixed the unit test and it is now working.

Thanks! We'll get one more approval and merge this PR, thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants