-
Notifications
You must be signed in to change notification settings - Fork 566
fix(rpc): eth_simulateV1 method handler crash #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChanHongMing
wants to merge
7
commits into
0xPolygon:v2.5.6-candidate
Choose a base branch
from
ChanHongMing:v2.5.6-candidate
base: v2.5.6-candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(rpc): eth_simulateV1 method handler crash #1955
ChanHongMing
wants to merge
7
commits into
0xPolygon:v2.5.6-candidate
from
ChanHongMing:v2.5.6-candidate
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamuikatsurgi
approved these changes
Dec 26, 2025
Member
|
Hey @ChanHongMing, I think one or few unit tests are failing, could you check and fix them? |
|
Author
|
Hello @kamuikatsurgi I have fixed the unit test and it is now working. |
Member
Thanks! We'll get one more approval and merge this PR, thanks for contributing. |
Raneet10
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Fixing the method handler crash issue when calling eth_simulateV1 method.
Changes
Bugfix (non-breaking change that solves an issue)
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
issue of the eth_simulateV1 is casued by BlobScheduleConfig being nil during calling to CalcBlobFee on Bor chains. After resolving this issue. Calling eth_simulateV1 result in "unexpected withdrawals" error, which indicate withdrawals are not supported in the block body. Then, this issue is resolved by setting it to Nil for bor chain. Finally, functions SetStateSync and SubscribeStateSyncEvent are added to simChainHeadReader so that it implements core.BorStateSyncer