Go 1.9.4: invalid flag in #cgo CFLAGS: -fno-common

[lloeki]

Caused by a security update to 1.9.4 which needs whitelisting. Reported upstream.

go build github.com/zchee/docker-machine-driver-xhyve/vendor/github.com/zchee/libhyperkit: invalid flag in #cgo CFLAGS: -fno-common

To work around this while the whitelisted flags get updated it may be possible to use $CGO_CFLAGS_ALLOW, otherwise one needs to go back to 1.9.3.

[youurayy]

Yes, builds with:

CGO_CFLAGS_ALLOW="-arch|x86_64|-fmessage-length=152|-fdiagnostics-show-note-include-stack|-fmacro-backtrace-limit=0" CGO_LDFLAGS_ALLOW="-arch|x86_64" make

I've seen the -arch reported upstream, the others may still need to get reported.

[lloeki]

the others may still need to get reported.

Indeed. Done.