Skip to content

Commit 6451ace

Browse files
committed
Coverage
1 parent 1ed9243 commit 6451ace

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

handler.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ func newWrappedResponseWriter(w http.ResponseWriter, r *http.Request, config Han
9292
return &wrappedResponseWriter{ResponseWriter: w, r: r, config: config}
9393
}
9494

95-
func (w *wrappedResponseWriter) Status() int {
96-
return w.status
97-
}
98-
9995
func (w *wrappedResponseWriter) Write(p []byte) (n int, err error) {
10096
if !w.wroteBody {
10197
w.wroteBody = true

signatures_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,6 +1059,24 @@ func TestVerifyRequest(t *testing.T) {
10591059
want: false,
10601060
wantErr: true,
10611061
},
1062+
{
1063+
name: "bad keyID but not verified", // this is NOT a failure
1064+
args: args{
1065+
signatureName: "sig-b22",
1066+
verifier: (func() Verifier {
1067+
pubKey, err := parseRsaPublicKeyFromPemStr(rsaPSSPubKey)
1068+
if err != nil {
1069+
t.Errorf("cannot parse public key: %v", err)
1070+
}
1071+
verifier, _ := NewRSAPSSVerifier("bad-key-id", *pubKey, NewVerifyConfig().
1072+
SetVerifyCreated(false).SetVerifyKeyID(false), *NewFields())
1073+
return *verifier
1074+
})(),
1075+
req: readRequest(httpreq1pssSelective),
1076+
},
1077+
want: true,
1078+
wantErr: false,
1079+
},
10621080
}
10631081
for _, tt := range tests {
10641082
t.Run(tt.name, func(t *testing.T) {

0 commit comments

Comments
 (0)