Skip to content

Commit 4ab3bc2

Browse files
committed
pyarray now inherits from pycontainer
1 parent b86826d commit 4ab3bc2

File tree

11 files changed

+348
-891
lines changed

11 files changed

+348
-891
lines changed

benchmark/CMakeLists.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,16 @@ set(XTENSOR_PYTHON_BENCHMARK
6262

6363
set(XTENSOR_PYTHON_BENCHMARK_TARGET benchmark_xtensor_python)
6464
add_library(${XTENSOR_PYTHON_BENCHMARK_TARGET} MODULE EXCLUDE_FROM_ALL
65-
${XTENSOR_PYTHON_BENCHMARK} ${XTENSOR_PYTHON_HEADERS})
65+
${XTENSOR_PYTHON_BENCHMARK} ${XTENSOR_PYTHON_HEADERS})
6666

6767
set_target_properties(${XTENSOR_PYTHON_BENCHMARK_TARGET} PROPERTIES PREFIX "")
6868
set_target_properties(${XTENSOR_PYTHON_BENCHMARK_TARGET} PROPERTIES SUFFIX "${PYTHON_MODULE_EXTENSION}")
6969

70-
if(APPLE)
70+
if (APPLE)
7171
target_link_libraries(${XTENSOR_PYTHON_BENCHMARK_TARGET} PRIVATE "-undefined dynamic_lookup")
72-
else()
72+
elseif (MSVC)
73+
target_link_libraries(${XTENSOR_PYTHON_BENCHMARK_TARGET} ${PYTHON_LIBRARIES})
74+
else ()
7375
target_link_libraries(${XTENSOR_PYTHON_BENCHMARK_TARGET} "-shared")
7476
endif()
7577

benchmark/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "pybind11/pybind11.h"
22
#include "pybind11/numpy.h"
3-
//#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION
3+
#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION
44
#include "numpy/arrayobject.h"
55
#include "xtensor/xtensor.hpp"
66
#include "xtensor/xarray.hpp"

benchmark/setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def __str__(self):
3434

3535
ext_modules = [
3636
Extension(
37-
'xtensor_python_benchmark',
37+
'benchmark_xtensor_python',
3838
['main.cpp'],
3939
include_dirs=[
4040
# Path to pybind11 headers
@@ -99,7 +99,7 @@ def build_extensions(self):
9999
build_ext.build_extensions(self)
100100

101101
setup(
102-
name='xtensor_python_benchmark',
102+
name='benchmark_xtensor_python',
103103
version=__version__,
104104
author='Sylvain Corlay',
105105
author_email='sylvain.corlay@gmail.com',

0 commit comments

Comments
 (0)