Skip to content

Commit 89b180d

Browse files
AB-xdevAB-xdev
committed
Fix CS
1 parent a0761bd commit 89b180d

6 files changed

Lines changed: 22 additions & 22 deletions

File tree

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/util/WebClientUtil.java renamed to bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/util/TransferNumberExtractor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,11 @@
3737
/**
3838
* Helps in communicating as web client.
3939
*/
40-
public final class WebClientUtil
40+
public final class TransferNumberExtractor
4141
{
4242
public static final String TAG_NAME_DATENTRANSFERNUMMER = "Datentransfernummer";
4343

44-
private WebClientUtil()
45-
{
46-
}
47-
48-
public static List<String> extractTransferNumberFromXml(final String xmlString) throws IOException
44+
public static List<String> extractFromXml(final String xmlString) throws IOException
4945
{
5046
try
5147
{
@@ -72,4 +68,8 @@ public static List<String> extractTransferNumberFromXml(final String xmlString)
7268
throw new IOException("An error occurred while parsing the transfer numbers.", e);
7369
}
7470
}
71+
72+
private TransferNumberExtractor()
73+
{
74+
}
7575
}

‎bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/webclient/WebClient.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import software.xdev.bzst.dip.client.model.configuration.BzstDipConfiguration;
3131
import software.xdev.bzst.dip.client.model.message.dac7.BzstDipRequestStatusResult;
3232
import software.xdev.bzst.dip.client.model.message.dac7.BzstDipSingleTransferResult;
33-
import software.xdev.bzst.dip.client.util.WebClientUtil;
33+
import software.xdev.bzst.dip.client.util.TransferNumberExtractor;
3434

3535

3636
/**
@@ -122,7 +122,7 @@ public List<String> requestResultLogs() throws IOException
122122
final String responseBody = new String(inputStream.readAllBytes(), StandardCharsets.UTF_8);
123123
LOGGER.debug("ResponseBody from data transfer number request:\n{}", responseBody);
124124

125-
return WebClientUtil.extractTransferNumberFromXml(responseBody);
125+
return TransferNumberExtractor.extractFromXml(responseBody);
126126
}
127127
}
128128

‎bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/ReportableSellerCsvFileParserTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package software.xdev.bzst.dip.client;
1717

1818
import static org.junit.jupiter.api.Assertions.assertEquals;
19-
import static software.xdev.bzst.dip.client.ConfigurationTestUtil.getConfigurationWithJksSigning;
19+
import static software.xdev.bzst.dip.client.TestSigningConfiguration.getConfigurationWithJksSigning;
2020

2121
import java.io.IOException;
2222
import java.io.Reader;

bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/ConfigurationTestUtil.java renamed to bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/TestSigningConfiguration.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,8 @@
2626
import software.xdev.bzst.dip.client.signing.SigningProviderByPem;
2727

2828

29-
public final class ConfigurationTestUtil
29+
public final class TestSigningConfiguration
3030
{
31-
private ConfigurationTestUtil()
32-
{
33-
}
34-
3531
public static BzstDipConfiguration getConfigurationWithJksSigning()
3632
{
3733
return createBuilderWithoutSigning()
@@ -63,4 +59,8 @@ private static BzstDipConfigurationBuilder createBuilderWithoutSigning()
6359
new BzstDipAddressFix("TestCity")
6460
);
6561
}
62+
63+
private TestSigningConfiguration()
64+
{
65+
}
6666
}

bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/WebClientUtilTest.java renamed to bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/TransferNumberExtractorTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@
2323

2424
import org.junit.jupiter.api.Test;
2525

26-
import software.xdev.bzst.dip.client.util.WebClientUtil;
26+
import software.xdev.bzst.dip.client.util.TransferNumberExtractor;
2727

2828

29-
class WebClientUtilTest
29+
class TransferNumberExtractorTest
3030
{
3131
@Test
3232
void throwExceptionCanNotParseToXmlTest()
3333
{
3434
final IOException thrown = assertThrows(
3535
IOException.class,
36-
() -> WebClientUtil.extractTransferNumberFromXml("12345")
36+
() -> TransferNumberExtractor.extractFromXml("12345")
3737
);
3838

3939
assertEquals("An error occurred while parsing the transfer numbers.", thrown.getMessage());
@@ -43,7 +43,7 @@ void throwExceptionCanNotParseToXmlTest()
4343
void noTransferNumbersTest() throws IOException
4444
{
4545
final List<String> dataTransferNumbers =
46-
WebClientUtil.extractTransferNumberFromXml(
46+
TransferNumberExtractor.extractFromXml(
4747
"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
4848
+ "<Datentransfernummern/>");
4949

@@ -54,7 +54,7 @@ void noTransferNumbersTest() throws IOException
5454
void transferNumbersTest() throws IOException
5555
{
5656
final List<String> dataTransferNumbers =
57-
WebClientUtil.extractTransferNumberFromXml(
57+
TransferNumberExtractor.extractFromXml(
5858
"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
5959
+ "<Datentransfernummern>"
6060
+ "<Datentransfernummer>2394headfsoiu</Datentransfernummer>"

‎bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/signing/XmlSignerTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.junit.jupiter.params.provider.Arguments;
2424
import org.junit.jupiter.params.provider.MethodSource;
2525

26-
import software.xdev.bzst.dip.client.ConfigurationTestUtil;
26+
import software.xdev.bzst.dip.client.TestSigningConfiguration;
2727
import software.xdev.bzst.dip.client.model.configuration.BzstDipConfiguration;
2828
import software.xdev.bzst.dip.client.xmldocument.XMLDocumentBodyCreator;
2929
import software.xdev.bzst.dip.client.xmldocument.XMLDocumentCreator;
@@ -34,8 +34,8 @@ class XmlSignerTest
3434
private static Stream<Arguments> provideConfigurations()
3535
{
3636
return Stream.of(
37-
Arguments.of(ConfigurationTestUtil.getConfigurationWithJksSigning()),
38-
Arguments.of(ConfigurationTestUtil.getConfigurationWithPemSigning())
37+
Arguments.of(TestSigningConfiguration.getConfigurationWithJksSigning()),
38+
Arguments.of(TestSigningConfiguration.getConfigurationWithPemSigning())
3939
);
4040
}
4141

0 commit comments

Comments
 (0)