Merge branch '5.1' into 5.x

* 5.1:
  [Contracts] add branch-aliases for dev-main
  [Cache] Make Redis initializers static
  [Messenger] Fixed typos in Connection
  [CI] Fixed build on AppVeyor
  Fix tests typo
  [Lock] Reset Key lifetime time before we acquire it
  [CI] Silence errors when remove file/dir on test tearDown()
  Fix tests
  Remove content-type check on toArray methods

Author: nicolas-grekas

src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php

@@ -142,7 +142,7 @@ protected function tearDown(): void
     {
         foreach ($this->files as $file) {
             if (file_exists($file)) {
-                unlink($file);
+                @unlink($file);
             }
         }
     }

src/Symfony/Bundle/FrameworkBundle/Tests/Command/XliffLintCommandTest.php

@@ -121,9 +121,9 @@ protected function tearDown(): void
     {
         foreach ($this->files as $file) {
             if (file_exists($file)) {
-                unlink($file);
+                @unlink($file);
             }
         }
-        rmdir(sys_get_temp_dir().'/xliff-lint-test');
+        @rmdir(sys_get_temp_dir().'/xliff-lint-test');
     }
 }

src/Symfony/Bundle/FrameworkBundle/Tests/Command/YamlLintCommandTest.php

@@ -168,9 +168,9 @@ protected function tearDown(): void
     {
         foreach ($this->files as $file) {
             if (file_exists($file)) {
-                unlink($file);
+                @unlink($file);
             }
         }
-        rmdir(sys_get_temp_dir().'/yml-lint-test');
+        @rmdir(sys_get_temp_dir().'/yml-lint-test');
     }
 }

src/Symfony/Component/Cache/Traits/RedisTrait.php

@@ -175,7 +175,7 @@ public static function createConnection($dsn, array $options = [])
             $connect = $params['persistent'] || $params['persistent_id'] ? 'pconnect' : 'connect';
             $redis = new $class();
 
-            $initializer = function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
+            $initializer = static function ($redis) use ($connect, $params, $dsn, $auth, $hosts) {
                 try {
                     @$redis->{$connect}($hosts[0]['host'] ?? $hosts[0]['path'], $hosts[0]['port'] ?? null, $params['timeout'], (string) $params['persistent_id'], $params['retry_interval']);
 
@@ -227,7 +227,7 @@ public static function createConnection($dsn, array $options = [])
                 $redis->setOption(\Redis::OPT_TCP_KEEPALIVE, $params['tcp_keepalive']);
             }
         } elseif (is_a($class, \RedisCluster::class, true)) {
-            $initializer = function () use ($class, $params, $dsn, $hosts) {
+            $initializer = static function () use ($class, $params, $dsn, $hosts) {
                 foreach ($hosts as $i => $host) {
                     $hosts[$i] = 'tcp' === $host['scheme'] ? $host['host'].':'.$host['port'] : $host['path'];
                 }

src/Symfony/Component/Config/Tests/ConfigCacheTest.php

@@ -30,7 +30,7 @@ protected function tearDown(): void
 
         foreach ($files as $file) {
             if (file_exists($file)) {
-                unlink($file);
+                @unlink($file);
             }
         }
     }

src/Symfony/Component/Config/Tests/Resource/FileExistenceResourceTest.php

@@ -30,7 +30,7 @@ protected function setUp(): void
     protected function tearDown(): void
     {
         if (file_exists($this->file)) {
-            unlink($this->file);
+            @unlink($this->file);
         }
     }
 

src/Symfony/Component/Config/Tests/Resource/FileResourceTest.php

@@ -30,11 +30,9 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        if (!file_exists($this->file)) {
-            return;
+        if (file_exists($this->file)) {
+            @unlink($this->file);
         }
-
-        unlink($this->file);
     }
 
     public function testGetResource()

src/Symfony/Component/Config/Tests/ResourceCheckerConfigCacheTest.php

@@ -31,7 +31,7 @@ protected function tearDown(): void
 
         foreach ($files as $file) {
             if (file_exists($file)) {
-                unlink($file);
+                @unlink($file);
             }
         }
     }

src/Symfony/Component/HttpClient/Response/CommonResponseTrait.php

@@ -88,12 +88,6 @@ public function toArray(bool $throw = true): array
             return $this->jsonData;
         }
 
-        $contentType = $this->headers['content-type'][0] ?? 'application/json';
-
-        if (!preg_match('/\bjson\b/i', $contentType)) {
-            throw new JsonException(sprintf('Response content-type is "%s" while a JSON-compatible one was expected for "%s".', $contentType, $this->getInfo('url')));
-        }
-
         try {
             $content = json_decode($content, true, 512, \JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? \JSON_THROW_ON_ERROR : 0));
         } catch (\JsonException $e) {

src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php

@@ -54,12 +54,6 @@ public function toArrayErrors()
             'message' => 'Response body is empty.',
         ];
 
-        yield [
-            'content' => '{}',
-            'responseHeaders' => ['content-type' => 'plain/text'],
-            'message' => 'Response content-type is "plain/text" while a JSON-compatible one was expected for "https://example.com/file.json".',
-        ];
-
         yield [
             'content' => 'not json',
             'responseHeaders' => [],