Remove include_metadata parameter from Ios:GitHelper.commit_version_bump to reflect the changes in the latest localization tooling

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_beta.rb

@@ -15,7 +15,7 @@ def self.run(params)
         Fastlane::Helper::Ios::VersionHelper.update_xc_configs(@new_beta_version, @short_version, @new_internal_version)
         UI.message 'Done!'
 
-        Fastlane::Helper::Ios::GitHelper.commit_version_bump(include_deliverfile: false, include_metadata: false)
+        Fastlane::Helper::Ios::GitHelper.commit_version_bump(include_deliverfile: false)
       end
 
       #####################################################

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb

@@ -20,7 +20,7 @@ def self.run(params)
         Fastlane::Helper::Ios::VersionHelper.update_xc_configs(@new_version, @new_short_version, @new_version_internal)
         UI.message 'Done!'
 
-        Fastlane::Helper::Ios::GitHelper.commit_version_bump(include_deliverfile: update_deliverfile, include_metadata: false)
+        Fastlane::Helper::Ios::GitHelper.commit_version_bump(include_deliverfile: update_deliverfile)
 
         UI.message 'Done.'
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb

@@ -30,8 +30,7 @@ def self.run(params)
         UI.message 'Done!'
 
         Fastlane::Helper::Ios::GitHelper.commit_version_bump(
-          include_deliverfile: !params[:skip_deliver],
-          include_metadata: false
+          include_deliverfile: !params[:skip_deliver]
         )
 
         UI.message 'Done.'

lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb

@@ -15,14 +15,10 @@ module GitHelper
         # @env PROJECT_NAME The name of the directory containing the project code (especially containing the Resources/ subfolder)
         #
         # @param [Bool] include_deliverfile If true (the default), includes the `fastlane/Deliverfile` in files being commited
-        # @param [Bool] include_metadata If true (the default), includes the `.pot` file (which typically contains an entry or release notes for the new version)
         #
-        def self.commit_version_bump(include_deliverfile: true, include_metadata: true)
+        def self.commit_version_bump(include_deliverfile: true)
           files_list = [File.join(env_project_root(), 'config', '.')]
           files_list.append File.join('fastlane', 'Deliverfile') if include_deliverfile
-          if include_metadata
-            files_list.append File.join(env_project_root(), env_project_name(), 'Resources', get_from_env!(key: 'APP_STORE_STRINGS_FILE_NAME'))
-          end
 
           Fastlane::Helper::GitHelper.commit(message: 'Bump version number', files: files_list, push: true)
         end

spec/ios_bump_version_release_spec.rb

@@ -23,7 +23,7 @@
       skip_deliver = false
 
       expect(Fastlane::Helper::Ios::VersionHelper).to receive(:update_fastlane_deliver).with(next_version_short)
-      expect(Fastlane::Helper::Ios::GitHelper).to receive(:commit_version_bump).with(include_deliverfile: !skip_deliver, include_metadata: false)
+      expect(Fastlane::Helper::Ios::GitHelper).to receive(:commit_version_bump).with(include_deliverfile: !skip_deliver)
 
       run_described_fastlane_action(
         skip_deliver: skip_deliver,
@@ -35,7 +35,7 @@
       skip_deliver = true
 
       expect(Fastlane::Helper::Ios::VersionHelper).not_to receive(:update_fastlane_deliver)
-      expect(Fastlane::Helper::Ios::GitHelper).to receive(:commit_version_bump).with(include_deliverfile: !skip_deliver, include_metadata: false)
+      expect(Fastlane::Helper::Ios::GitHelper).to receive(:commit_version_bump).with(include_deliverfile: !skip_deliver)
 
       run_described_fastlane_action(
         skip_deliver: skip_deliver,

spec/ios_git_helper_spec.rb

@@ -24,36 +24,20 @@
       allow(described_class).to receive(:get_from_env!).and_return('')
     end
 
-    it 'commits and pushes the app version bump with deliver file and metadata' do
-      expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
-        expect_commited_files(files: arg[:files], names: %w[config Deliverfile Resources])
-      end
-
-      described_class.commit_version_bump()
-    end
-
-    it 'commits and pushes the app version bump with deliver file only' do
+    it 'commits and pushes the app version bump with deliver file' do
       expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
         expect_commited_files(files: arg[:files], names: %w[config Deliverfile])
       end
 
-      described_class.commit_version_bump(include_metadata: false)
-    end
-
-    it 'commits and pushes the app version bump with metadata only' do
-      expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
-        expect_commited_files(files: arg[:files], names: %w[config Resources])
-      end
-
-      described_class.commit_version_bump(include_deliverfile: false)
+      described_class.commit_version_bump()
     end
 
-    it 'commits and pushes the app version bump config files only, no deliver file or metadata' do
+    it 'commits and pushes the app version bump without the deliver file' do
       expect(Fastlane::Helper::GitHelper).to receive(:commit) do |arg|
         expect_commited_files(files: arg[:files], names: %w[config])
       end
 
-      described_class.commit_version_bump(include_metadata: false, include_deliverfile: false)
+      described_class.commit_version_bump(include_deliverfile: false)
     end
 
     def expect_commited_files(files:, names:)