Skip to content

Comments

fix for missing lang="en" in some UI pages#5381

Merged
softhack007 merged 1 commit intomainfrom
ui_lang_en
Feb 19, 2026
Merged

fix for missing lang="en" in some UI pages#5381
softhack007 merged 1 commit intomainfrom
ui_lang_en

Conversation

@softhack007
Copy link
Member

@softhack007 softhack007 commented Feb 19, 2026

This PR adds the lang="en" attribute to all html pages where a language identifier was still missing.

Previously when opening the welcome page or update page, some smart browsers suggested to "translate from Danish".

Summary by CodeRabbit

  • Style
    • Improved HTML standards compliance and accessibility by adding language attribute declarations to interface pages, enabling proper language detection for browsers and assistive technologies.

stops some _smart_ browsers from suggesting to "translate from Danish".
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Walkthrough

Added lang="en" language attribute to the root HTML element across eleven HTML files in the wled00/data directory. No functional, structural, or behavioral changes; purely semantic/accessibility enhancement.

Changes

Cohort / File(s) Summary
HTML Language Attribute Enhancement
wled00/data/*.htm, wled00/data/cpal/cpal.htm, wled00/data/icons-ui/demo.html, wled00/data/pixart/pixart.htm
Added lang="en" attribute to the root HTML element across all files for improved accessibility and semantic markup; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix for missing lang="en" in some UI pages' directly and clearly summarizes the primary change: adding the lang="en" attribute to HTML pages that lacked it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ui_lang_en

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as outdated.

@DedeHai
Copy link
Collaborator

DedeHai commented Feb 19, 2026

regarding UI (and merge conflicts) should I merge #5328?

@softhack007
Copy link
Member Author

@DedeHai yes.
Please double-check if renaming "Server Description" is harmless, and then lets merge #5328 before this one.

@softhack007 softhack007 merged commit 6240ee6 into main Feb 19, 2026
53 checks passed
@softhack007 softhack007 deleted the ui_lang_en branch February 19, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants