Expression 2 core preprocessor parses strings in attributes incorrectly

[stepa2]

The preprocessor only allows things that match ?[%w,_ =\"]* pattern in attributes.
This includes strings too, so strings containing e.g. dots (.) or other punctuation break the preprocessor.

I discovered while fixing ACE-Project-Team/ArmoredCombatExtended#201 .

Better string rules (anything from quote to paired unescaped quote makes a string) will probably require replacing regex-based parser with something more powerful.

wire/lua/entities/gmod_wire_expression2/core/extpp.lua

Line 150 in 23de4fc

for a_begin, attributes, h_begin, ret, thistype, colon, name, args, whitespace, equals, h_end in contents:gmatch("()(%[?[%w,_ =\"]*%]?)[\r\n\t ]*()e2function%s+(" .. p_typename .. ")%s+([a-z0-9]-)%s*(:?)%s*(" .. p_func_operator .. ")%(([^)]*)%)(%s*)(=?)%s*()") do

[Denneisk]

I thought I responded to something like this before.

It's a known bug but most conversation about it has been deferred to "We just work around it".

I had something of a solution created but it was denied because the preprocessor was supposed to be deprecated, but that never happened.