Skip to content

Commit ccd894f

Browse files
authored
Update README.md
1 parent ef6bc41 commit ccd894f

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

README.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,22 @@
22

33
A minimal chess engine (not UCI, not XBoard, but only search and evaluation functions)
44

5-
Source: Disservin/chess-library/include
5+
Source: Disservin/chess-library
6+
7+
After seeing ["BEST C++ CODE ever written" // Code Review](https://www.youtube.com/watch?v=NeHjMNBsVfs) and [NicholasMaurer2005/ChessConsole](https://github.com/NicholasMaurer2005/ChessConsole) (the github page related) I see some major problems:
8+
- Displacement of methods [1] [2] [3] [4] [5]
9+
- Use `std::endl` [6]
10+
- Use `rand()` [7] [8]
11+
- `using namespace std;` in header (already covered)
12+
- Optimize branch prediction [9] [10]
13+
Citations:
14+
- [1]: [Engine::makeMove](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/Engine.cpp#L478)
15+
- [2]: [Engine::printBoard](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/Engine.cpp#L376)
16+
- [3]: [Engine::inputAndParseMove](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/Engine.cpp#L394)
17+
- [4]: [Engine::squareToIndex](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/Engine.cpp#L470)
18+
- [5]: [Engine::kingInCheck](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/Engine.cpp#L346)
19+
- [6]: [std::endl](https://en.cppreference.com/w/cpp/io/manip/endl)
20+
- [7]: [How good is the current implementations of rand() in C?](https://scicomp.stackexchange.com/questions/30479/how-good-are-current-implementations-of-rand-in-c)
21+
- [8]: [Faster than rand()?](https://stackoverflow.com/questions/26237419/faster-than-rand)
22+
- [9]: [MoveList::FindMove](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/MoveList.cpp#L35)
23+
- [10]: [MoveList::FindCastleMove](https://github.com/NicholasMaurer2005/ChessConsole/blob/master/ChessConsole/MoveList.cpp#L35)

0 commit comments

Comments
 (0)