Skip to content

Commit aa95bc0

Browse files
committed
utils: print "RSA PRIVATE KEY" instead of "PRIVATE KEY"
1 parent a9627b4 commit aa95bc0

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

test/integration/smoke/test_network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2349,7 +2349,7 @@ def _get_ip_address_output(self, ssh):
23492349
return '\n'.join(res)
23502350

23512351
@attr(tags=["advanced", "shared"], required_hardware="true")
2352-
def test_01_deployVMInSharedNetwork(self):
2352+
def test_01_deployVMInSharedNetworkWithConfigDrive(self):
23532353
try:
23542354
self.virtual_machine = VirtualMachine.create(self.apiclient, self.services["virtual_machine"],
23552355
networkids=[self.shared_network.id, self.isolated_network.id],

utils/src/main/java/com/cloud/utils/ssh/SSHKeysHelper.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package com.cloud.utils.ssh;
2121

2222
import java.io.ByteArrayOutputStream;
23+
import java.io.StringWriter;
2324
import java.math.BigInteger;
2425
import java.nio.ByteBuffer;
2526
import java.security.KeyPair;
@@ -30,6 +31,8 @@
3031

3132
import org.apache.cloudstack.utils.security.CertUtils;
3233
import org.apache.commons.codec.binary.Base64;
34+
import org.bouncycastle.util.io.pem.PemObject;
35+
import org.bouncycastle.util.io.pem.PemWriter;
3336

3437
public class SSHKeysHelper {
3538

@@ -139,7 +142,12 @@ private static void writeBigInt(ByteArrayOutputStream out, BigInteger value) thr
139142

140143
public String getPrivateKey() {
141144
try {
142-
return CertUtils.privateKeyToPem(keyPair.getPrivate());
145+
final PemObject pemObject = new PemObject("RSA PRIVATE KEY", keyPair.getPrivate().getEncoded());
146+
final StringWriter sw = new StringWriter();
147+
try (final PemWriter pw = new PemWriter(sw)) {
148+
pw.writeObject(pemObject);
149+
}
150+
return sw.toString();
143151
} catch (Exception e) {
144152
e.printStackTrace();
145153
}

0 commit comments

Comments
 (0)