From f868755e3b0b23e9ec522c6ce27357a24f26b88e Mon Sep 17 00:00:00 2001 From: Matthias Pigulla Date: Fri, 23 Jan 2026 10:28:42 +0100 Subject: [PATCH 1/3] Configure `kernel.secret` in tests --- tests/Fixtures/TestKernel.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Fixtures/TestKernel.php b/tests/Fixtures/TestKernel.php index 759ff96..ac1edae 100644 --- a/tests/Fixtures/TestKernel.php +++ b/tests/Fixtures/TestKernel.php @@ -26,6 +26,7 @@ protected function configureContainer(ContainerConfigurator $container): void { $container->extension('framework', [ 'test' => true, + 'secret' => 'dont-tell-mum', ] + (Kernel::VERSION_ID < 70000 ? ['annotations' => ['enabled' => false]] : [])); $services = $container->services(); From badd4f157cf7c05041a11884ee37a60f4377381b Mon Sep 17 00:00:00 2001 From: mpdude <1202333+mpdude@users.noreply.github.com> Date: Fri, 23 Jan 2026 09:29:12 +0000 Subject: [PATCH 2/3] Fix CS with PHP-CS-Fixer --- tests/DependencyInjection/Compiler/TagRewriterPassTest.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/DependencyInjection/Compiler/TagRewriterPassTest.php b/tests/DependencyInjection/Compiler/TagRewriterPassTest.php index 030432a..8685f2f 100644 --- a/tests/DependencyInjection/Compiler/TagRewriterPassTest.php +++ b/tests/DependencyInjection/Compiler/TagRewriterPassTest.php @@ -4,7 +4,6 @@ use PHPUnit\Framework\TestCase; use Symfony\Component\DependencyInjection\ChildDefinition; -use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\Definition; use Webfactory\Html5TagRewriter\Implementation\Html5TagRewriter; @@ -13,7 +12,6 @@ use Webfactory\Html5TagRewriterBundle\DependencyInjection\Compiler\TagRewriterPass; use Webfactory\Html5TagRewriterBundle\Tests\Fixtures\Handler\TestDefaultHandler; use Webfactory\Html5TagRewriterBundle\Twig\Extension; -use Webfactory\Html5TagRewriterBundle\WebfactoryHtml5TagRewriterBundle; class TagRewriterPassTest extends TestCase { From 27ea43eb1494fa5e06835e3f7d7cc2101ab205f0 Mon Sep 17 00:00:00 2001 From: Matthias Pigulla Date: Fri, 23 Jan 2026 13:22:24 +0100 Subject: [PATCH 3/3] Use "Interface proxying" to enable lazy serivces for `final` classes https://symfony.com/doc/6.4/service_container/lazy_services.html#interface-proxifying --- src/DependencyInjection/Compiler/TagRewriterPass.php | 1 + src/Resources/config/services.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/DependencyInjection/Compiler/TagRewriterPass.php b/src/DependencyInjection/Compiler/TagRewriterPass.php index 1f009b1..0960980 100644 --- a/src/DependencyInjection/Compiler/TagRewriterPass.php +++ b/src/DependencyInjection/Compiler/TagRewriterPass.php @@ -72,6 +72,7 @@ private function setupTagRewriters(ContainerBuilder $container): void $definition = clone $prototype; $definition->setAbstract(false); $definition->setLazy(true); + $definition->addTag('proxy', ['interface' => TagRewriter::class]); $container->setDefinition($serviceId, $definition); } diff --git a/src/Resources/config/services.php b/src/Resources/config/services.php index 8eccffc..0a72a69 100644 --- a/src/Resources/config/services.php +++ b/src/Resources/config/services.php @@ -18,7 +18,8 @@ // Default TagRewriter (will be configured by compiler pass) $services->set('webfactory.html5_tag_rewriter.instance.default', Html5TagRewriter::class) - ->lazy(); + ->lazy() + ->tag('proxy', ['interface' => TagRewriter::class]); // Autowiring alias: TagRewriter interface -> default rewriter $services->alias(TagRewriter::class, 'webfactory.html5_tag_rewriter.instance.default');