Skip to content

Change skip_broken and fail_on_warnings options #218

@neomilium

Description

@neomilium

From my point of view, we should change our approach about two options skip_broken and fail_on_warnings:

  • skip_broken is not relevant option as, for example, an "update" that does not contain modification is consider as broken
  • skip_broken sounds me to be the default so turning option from skip_broken to fail_fast makes me sense to me
  • fail_on_warnings (ie. exit code sets to 1 or higher) could be an option if we choose to introduction a distinguish between real error (e.g. unable to process a template) and a warning (e.g. no files are updated after an update run)
  • finally, we should always fail earlier (with an exit code sets to 1 or higher) if an error occurred, so fail_fast will be relevant in case of warnings

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions