check.sh: shellcheck

Author: classabbyamp

check.sh

@@ -3,28 +3,28 @@
 # reset variable so it doesn't use the environment one
 MISSING=
 
-echo -n "Checking for mdbook-linkcheck ... "
+printf "Checking for mdbook-linkcheck ... "
 if ! command -v mdbook-linkcheck; then
     MISSING="$MISSING mdbook-linkcheck"
     echo "not found"
 fi
 
-echo -n "Checking for vmdfmt ... "
+printf "Checking for vmdfmt ... "
 if ! command -v vmdfmt; then
     MISSING="$MISSING vmdfmt"
     echo "not found"
 fi
 
 if [ "$MISSING" ]; then
 
-    echo -n "Checking for xbps-install ... "
+    printf "Checking for xbps-install ... "
     if ! command -v xbps-install; then
         echo "not found"
         echo "Please manually install: $MISSING"
         exit 1    
     fi
 
-    echo -n "Checking for sudo ... "
+    printf "Checking for sudo ... "
     if command -v sudo; then
         SU_CMD='sudo'
     else
@@ -39,14 +39,14 @@ if [ "$MISSING" ]; then
         fi
     fi
 
-    echo "\nTrying to install ${MISSING## } ... "
+    printf "\nTrying to install %s ... " "${MISSING## }"
     $SU_CMD xbps-install $MISSING
     echo
 
     # Check whether executables are now present.
-    
+
     for i in $MISSING; do
-        if ! command -v $i 2>&1 >/dev/null; then
+        if ! command -v "$i" >/dev/null 2>&1; then
             UNAVAILABLE="$UNAVAILABLE $i"
         fi
     done
@@ -60,7 +60,7 @@ fi
 
 vmdfmt -l -w src/
 
-if command -v mdbook 2>&1 >/dev/null; then
+if command -v mdbook >/dev/null 2>&1; then
     echo "Building book and checking links with mdbook ..."
     mdbook build
 else