Merge pull request #725 from utopia-php/chore-test-numeric-id

Add test asserting numeric ID stays string

Author: abnegate

src/Database/Database.php

@@ -3595,7 +3595,7 @@ private function populateDocumentRelationships(Document $collection, Document $d
             $side = $relationship['options']['side'];
 
             // Clone queries to avoid mutation affecting subsequent documents
-            $queries = array_map(fn($query) => clone $query, $selects[$key] ?? []);
+            $queries = array_map(fn ($query) => clone $query, $selects[$key] ?? []);
 
             if (!empty($value)) {
                 $k = $relatedCollection->getId() . ':' . $value . '=>' . $collection->getId() . ':' . $document->getId();

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -305,6 +305,35 @@ public function testCreateDocument(): Document
         return $document;
     }
 
+    public function testCreateDocumentNumericalId(): void
+    {
+        /** @var Database $database */
+        $database = static::getDatabase();
+
+        $database->createCollection('numericalIds');
+
+        $this->assertEquals(true, $database->createAttribute('numericalIds', 'name', Database::VAR_STRING, 128, true));
+
+        // Test creating a document with an entirely numerical ID
+        $numericalIdDocument = $database->createDocument('numericalIds', new Document([
+            '$id' => '123456789',
+            '$permissions' => [
+                Permission::read(Role::any()),
+            ],
+            'name' => 'Test Document with Numerical ID',
+        ]));
+
+        $this->assertIsString($numericalIdDocument->getId());
+        $this->assertEquals('123456789', $numericalIdDocument->getId());
+        $this->assertEquals('Test Document with Numerical ID', $numericalIdDocument->getAttribute('name'));
+
+        // Verify we can retrieve the document
+        $retrievedDocument = $database->getDocument('numericalIds', '123456789');
+        $this->assertIsString($retrievedDocument->getId());
+        $this->assertEquals('123456789', $retrievedDocument->getId());
+        $this->assertEquals('Test Document with Numerical ID', $retrievedDocument->getAttribute('name'));
+    }
+
     public function testCreateDocuments(): void
     {
         $count = 3;