replace StringConcatenation usages with StringBuilder

Author: PhilippSalvisberg

sqldev/src/main/java/org/utplsql/sqldev/dal/UtplsqlDao.java

@@ -23,7 +23,6 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import org.eclipse.xtend2.lib.StringConcatenation;
 import org.eclipse.xtext.xbase.lib.CollectionLiterals;
 import org.oddgen.sqldev.generators.model.Node;
 import org.springframework.dao.DataAccessException;
@@ -254,7 +253,7 @@ public Boolean doInCallableStatement(final CallableStatement cs) throws SQLExcep
                 return found > 0;
             } else {
                 // using internal API (deprecated, not accessible in latest version)
-                StringConcatenation sb = new StringConcatenation();
+                StringBuilder sb = new StringBuilder();
                 sb.append("SELECT count(\n");
                 sb.append("          CASE\n");
                 sb.append("             WHEN a.name = 'test'\n");
@@ -428,7 +427,7 @@ public List<String> units(final String objectType, final String objectName) {
      *             if there is a problem
      */
     public List<Node> testables(final String objectType) {
-        StringConcatenation sb = new StringConcatenation();
+        StringBuilder sb = new StringBuilder();
         if ("PACKAGE".equals(objectType)) {
             if (normalizedUtPlsqlVersionNumber() >= FIRST_VERSION_WITH_ANNOTATION_API) {
                 // using API available since 3.1.3
@@ -1049,7 +1048,7 @@ public String doInCallableStatement(final CallableStatement cs) throws SQLExcept
      * @return the object type, e.g. PACKAGE BODY, TYPE BODY, PROCEDURE, FUNCTION
      */
     public String getObjectType(final String owner, final String objectName) {
-        StringConcatenation sb = new StringConcatenation();
+        StringBuilder sb = new StringBuilder();
         sb.append("SELECT object_type\n");
         sb.append("  FROM (\n");
         sb.append("          SELECT object_type\n");

sqldev/src/main/java/org/utplsql/sqldev/menu/UtplsqlController.java

@@ -28,7 +28,6 @@
 
 import javax.swing.JEditorPane;
 
-import org.eclipse.xtend2.lib.StringConcatenation;
 import org.utplsql.sqldev.coverage.CodeCoverageReporter;
 import org.utplsql.sqldev.dal.RealtimeReporterDao;
 import org.utplsql.sqldev.dal.UtplsqlDao;
@@ -320,7 +319,7 @@ public void runTest(final Context context) {
         final View view = context.getView();
         final Node node = context.getNode();
         final PreferenceModel preferences = PreferenceModel.getInstance(Preferences.getPreferences());
-        final StringConcatenation sb = new StringConcatenation();
+        final StringBuilder sb = new StringBuilder();
         sb.append("Run utPLSQL from view ");
         sb.append(view != null ? view.getClass().getName() : "???");
         sb.append(" and node ");
@@ -417,7 +416,7 @@ public List<String> dependencies(final Context context, final String connectionN
     public void codeCoverage(final Context context) {
         final View view = context.getView();
         final Node node = context.getNode();
-        final StringConcatenation sb = new StringConcatenation();
+        final StringBuilder sb = new StringBuilder();
         sb.append("Code coverage from view ");
         sb.append(view != null ? view.getClass().getName() : "???");
         sb.append(" and node ");
@@ -474,7 +473,7 @@ public void codeCoverage(final Context context) {
     public void generateTest(final Context context) {
         final View view = context.getView();
         final Node node = context.getNode();
-        final StringConcatenation sb = new StringConcatenation();
+        final StringBuilder sb = new StringBuilder();
         sb.append("Generate utPLSQL test from view ");
         sb.append(view != null ? view.getClass().getName() : "???");
         sb.append(" and node ");

sqldev/src/main/java/org/utplsql/sqldev/model/runner/Expectation.java

@@ -18,7 +18,6 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import org.eclipse.xtend2.lib.StringConcatenation;
 import org.springframework.core.style.ToStringCreator;
 import org.utplsql.sqldev.model.UtplsqlToStringStyler;
 
@@ -50,7 +49,7 @@ public String getFailureText() {
     }
 
     public String getShortFailureText() {
-        final StringConcatenation sb = new StringConcatenation();
+        final StringBuilder sb = new StringBuilder();
         if (description != null) {
             sb.append(description);
             sb.append(" (line ");