feat: add api v1 standard error response

Author: kridai

tests/unit/base/test_version.py

@@ -5,9 +5,8 @@
 from tests import IntegrationTestCase
 from tests.holodeck import Request
 from twilio.base.api_v1_version import ApiV1Version
-from twilio.base.exceptions import TwilioRestException, TwilioServiceException
+from twilio.base.exceptions import TwilioServiceException
 from twilio.base.page import Page
-from twilio.base.version import Version
 from twilio.http.response import Response
 
 
@@ -155,9 +154,7 @@ def test_exception_rfc9457_compliant(self):
         self.assertEqual(exception.status, 400)
         self.assertEqual(exception.code, 20001)
         self.assertEqual(exception.detail, "The 'PhoneNumber' parameter is required.")
-        self.assertEqual(
-            exception.instance, "/api/v1/accounts/AC123/calls/CA456"
-        )
+        self.assertEqual(exception.instance, "/api/v1/accounts/AC123/calls/CA456")
         self.assertEqual(exception.method, "POST")
         self.assertEqual(exception.uri, "/test")
 
@@ -225,14 +222,11 @@ def test_exception_with_error_payload_parameter(self):
             "title": "Invalid parameter",
             "status": 400,
             "code": 20001,
-            "detail": "Pre-parsed error payload"
+            "detail": "Pre-parsed error payload",
         }
 
         exception = ApiV1Version.exception(
-            method="POST",
-            uri="/test",
-            response=response,
-            error_payload=error_payload
+            method="POST", uri="/test", response=response, error_payload=error_payload
         )
 
         self.assertIsInstance(exception, TwilioServiceException)
@@ -307,7 +301,9 @@ def test_parse_delete_with_rfc9457_error(self):
 
         exception = context.exception
         self.assertEqual(exception.title, "Forbidden")
-        self.assertEqual(exception.detail, "You do not have permission to delete this resource")
+        self.assertEqual(
+            exception.detail, "You do not have permission to delete this resource"
+        )
 
     def test_parse_create_with_rfc9457_error(self):
         """Test that _parse_create raises TwilioServiceException for RFC-9457 errors"""

twilio/base/exceptions.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 import sys
-from typing import Optional, List, Dict, Any
+from typing import Optional, List, Dict
 
 
 class TwilioException(Exception):
@@ -145,47 +145,63 @@ def yellow(words: str) -> str:
                 "\n{red_error} {request_was}\n\n{http_line}\n\n{twilio_returned}\n".format(
                     red_error=red("HTTP Error"),
                     request_was=white("Your request was:"),
-                    http_line=teal("%s %s" % (self.method, self.uri)) if self.uri else teal("(no URI)"),
+                    http_line=(
+                        teal("%s %s" % (self.method, self.uri))
+                        if self.uri
+                        else teal("(no URI)")
+                    ),
                     twilio_returned=white("Twilio returned the following information:"),
                 )
             ]
 
             # Title and detail
-            msg_parts.append("\n{title_label}: {title}\n".format(
-                title_label=white("Title"),
-                title=blue(self.title),
-            ))
+            msg_parts.append(
+                "\n{title_label}: {title}\n".format(
+                    title_label=white("Title"),
+                    title=blue(self.title),
+                )
+            )
 
             if self.detail:
-                msg_parts.append("{detail_label}: {detail}\n".format(
-                    detail_label=white("Detail"),
-                    detail=blue(self.detail),
-                ))
+                msg_parts.append(
+                    "{detail_label}: {detail}\n".format(
+                        detail_label=white("Detail"),
+                        detail=blue(self.detail),
+                    )
+                )
 
             # Code and status
-            msg_parts.append("{code_label}: {code} | {status_label}: {status}\n".format(
-                code_label=white("Error Code"),
-                code=blue(str(self.code)),
-                status_label=white("Status"),
-                status=blue(str(self.status)),
-            ))
+            msg_parts.append(
+                "{code_label}: {code} | {status_label}: {status}\n".format(
+                    code_label=white("Error Code"),
+                    code=blue(str(self.code)),
+                    status_label=white("Status"),
+                    status=blue(str(self.status)),
+                )
+            )
 
             # Validation errors if present
             if self.errors:
-                msg_parts.append("\n{validation_label}:\n".format(
-                    validation_label=white("Validation Errors"),
-                ))
+                msg_parts.append(
+                    "\n{validation_label}:\n".format(
+                        validation_label=white("Validation Errors"),
+                    )
+                )
                 for error in self.errors:
-                    msg_parts.append("  {pointer}: {detail}\n".format(
-                        pointer=yellow(error.get("pointer", "(unknown field)")),
-                        detail=error.get("detail", "(no detail)"),
-                    ))
+                    msg_parts.append(
+                        "  {pointer}: {detail}\n".format(
+                            pointer=yellow(error.get("pointer", "(unknown field)")),
+                            detail=error.get("detail", "(no detail)"),
+                        )
+                    )
 
             # Documentation link
-            msg_parts.append("\n{more_info}\n\n{uri}\n\n".format(
-                more_info=white("More information may be available here:"),
-                uri=blue(self.type),
-            ))
+            msg_parts.append(
+                "\n{more_info}\n\n{uri}\n\n".format(
+                    more_info=white("More information may be available here:"),
+                    uri=blue(self.type),
+                )
+            )
 
             return "".join(msg_parts)
         else: