From 138451f853b07dbe30637c340cca1601e07acd10 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Tue, 9 Sep 2025 13:22:55 -0700 Subject: [PATCH 1/5] Notify ZJIT CI failures --- .github/workflows/zjit-macos.yml | 6 ++++++ .github/workflows/zjit-ubuntu.yml | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/.github/workflows/zjit-macos.yml b/.github/workflows/zjit-macos.yml index 53732103ec44d6..456854510ee756 100644 --- a/.github/workflows/zjit-macos.yml +++ b/.github/workflows/zjit-macos.yml @@ -120,6 +120,12 @@ jobs: TESTS: ${{ matrix.tests }} continue-on-error: ${{ matrix.continue-on-test_task || false }} + - uses: ./.github/actions/slack + with: + label: ${{ matrix.test_task }} ${{ matrix.configure }} + SLACK_WEBHOOK_URL: ${{ secrets.SIMPLER_ALERTS_URL }} # ruby-lang slack: ruby/simpler-alerts-bot + if: ${{ failure() }} + result: if: ${{ always() }} name: ${{ github.workflow }} result diff --git a/.github/workflows/zjit-ubuntu.yml b/.github/workflows/zjit-ubuntu.yml index 76b5b2c48948a8..8dd4d44fc51231 100644 --- a/.github/workflows/zjit-ubuntu.yml +++ b/.github/workflows/zjit-ubuntu.yml @@ -162,6 +162,12 @@ jobs: TESTS: ${{ matrix.tests }} continue-on-error: ${{ matrix.continue-on-test_task || false }} + - uses: ./.github/actions/slack + with: + label: ${{ matrix.test_task }} ${{ matrix.configure }} + SLACK_WEBHOOK_URL: ${{ secrets.SIMPLER_ALERTS_URL }} # ruby-lang slack: ruby/simpler-alerts-bot + if: ${{ failure() }} + result: if: ${{ always() }} name: ${{ github.workflow }} result From d14b4a7008161543f7d979d503f8c4d3b9660e69 Mon Sep 17 00:00:00 2001 From: Stan Lo Date: Tue, 9 Sep 2025 21:25:12 +0100 Subject: [PATCH 2/5] ZJIT: Remove unneeded omission for optional param test (#14488) --- test/ruby/test_zjit.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/test/ruby/test_zjit.rb b/test/ruby/test_zjit.rb index 1d80093d57d47a..5f59f9fc02b240 100644 --- a/test/ruby/test_zjit.rb +++ b/test/ruby/test_zjit.rb @@ -487,7 +487,6 @@ def test end def test_invokebuiltin - omit 'Test fails at the moment due to not handling optional parameters' assert_compiles '["."]', %q{ def test = Dir.glob(".") test From 9d0b621b051c0f3cc356c9bedf081456f1d7dfd6 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Tue, 9 Sep 2025 13:40:00 -0700 Subject: [PATCH 3/5] ZJIT: Resurrect --seed to stabilize CI ref: https://github.com/ruby/ruby/pull/14459 --- .github/workflows/zjit-macos.yml | 1 + .github/workflows/zjit-ubuntu.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/zjit-macos.yml b/.github/workflows/zjit-macos.yml index 456854510ee756..42d553b1b1e9fa 100644 --- a/.github/workflows/zjit-macos.yml +++ b/.github/workflows/zjit-macos.yml @@ -35,6 +35,7 @@ jobs: - test_task: 'check' configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' + testopts: '--seed=11831' specopts: '-T --zjit-call-threshold=1' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb diff --git a/.github/workflows/zjit-ubuntu.yml b/.github/workflows/zjit-ubuntu.yml index 8dd4d44fc51231..e2327f185a9f7c 100644 --- a/.github/workflows/zjit-ubuntu.yml +++ b/.github/workflows/zjit-ubuntu.yml @@ -54,6 +54,7 @@ jobs: - test_task: 'check' configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' + testopts: '--seed=18140' specopts: '-T --zjit-call-threshold=1' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb From a734c04b385e8e679609318cb5fc4bdc3e5750ce Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Tue, 9 Sep 2025 13:48:22 -0700 Subject: [PATCH 4/5] Revert "ZJIT: Resurrect --seed to stabilize CI" This reverts commit 9d0b621b051c0f3cc356c9bedf081456f1d7dfd6. It didn't work for `make check`. I'll fix it in a PR. --- .github/workflows/zjit-macos.yml | 1 - .github/workflows/zjit-ubuntu.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/zjit-macos.yml b/.github/workflows/zjit-macos.yml index 42d553b1b1e9fa..456854510ee756 100644 --- a/.github/workflows/zjit-macos.yml +++ b/.github/workflows/zjit-macos.yml @@ -35,7 +35,6 @@ jobs: - test_task: 'check' configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' - testopts: '--seed=11831' specopts: '-T --zjit-call-threshold=1' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb diff --git a/.github/workflows/zjit-ubuntu.yml b/.github/workflows/zjit-ubuntu.yml index e2327f185a9f7c..8dd4d44fc51231 100644 --- a/.github/workflows/zjit-ubuntu.yml +++ b/.github/workflows/zjit-ubuntu.yml @@ -54,7 +54,6 @@ jobs: - test_task: 'check' configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' - testopts: '--seed=18140' specopts: '-T --zjit-call-threshold=1' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb From 8f040a571b2b8d9da669340351d55f2283a9832a Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Tue, 9 Sep 2025 14:17:39 -0700 Subject: [PATCH 5/5] ZJIT: Resurrect --seed to stabilize CI (#14489) --- .github/workflows/zjit-macos.yml | 3 ++- .github/workflows/zjit-ubuntu.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/zjit-macos.yml b/.github/workflows/zjit-macos.yml index 456854510ee756..8f2ca884b16ef8 100644 --- a/.github/workflows/zjit-macos.yml +++ b/.github/workflows/zjit-macos.yml @@ -36,6 +36,7 @@ jobs: configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' specopts: '-T --zjit-call-threshold=1' + test_all_opts: '--seed=46450' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb configure: '--enable-yjit=dev --enable-zjit' @@ -117,7 +118,7 @@ jobs: TEST_BUNDLED_GEMS_ALLOW_FAILURES: '' SYNTAX_SUGGEST_TIMEOUT: '5' PRECHECK_BUNDLED_GEMS: 'no' - TESTS: ${{ matrix.tests }} + TESTS: ${{ matrix.test_all_opts }} continue-on-error: ${{ matrix.continue-on-test_task || false }} - uses: ./.github/actions/slack diff --git a/.github/workflows/zjit-ubuntu.yml b/.github/workflows/zjit-ubuntu.yml index 8dd4d44fc51231..3dfa8260a80fc1 100644 --- a/.github/workflows/zjit-ubuntu.yml +++ b/.github/workflows/zjit-ubuntu.yml @@ -55,6 +55,7 @@ jobs: configure: '--enable-zjit=dev' run_opts: '--zjit-call-threshold=1' specopts: '-T --zjit-call-threshold=1' + test_all_opts: '--seed=39471' - test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb configure: '--enable-yjit --enable-zjit=dev' @@ -159,7 +160,7 @@ jobs: SYNTAX_SUGGEST_TIMEOUT: '5' ZJIT_BINDGEN_DIFF_OPTS: '--exit-code' LIBCLANG_PATH: ${{ matrix.libclang_path }} - TESTS: ${{ matrix.tests }} + TESTS: ${{ matrix.test_all_opts }} continue-on-error: ${{ matrix.continue-on-test_task || false }} - uses: ./.github/actions/slack