code review fixes

Author: mpcgrid

apps/webapp/app/components/logs/LogDetailView.tsx

@@ -105,6 +105,16 @@ export function LogDetailView({ logId, initialLog, onClose, searchTerm }: LogDet
   // Handle keyboard shortcuts
   useEffect(() => {
     const handleKeyDown = (e: KeyboardEvent) => {
+      const target = e.target as HTMLElement;
+      if (target && (
+        target.tagName === "INPUT" ||
+        target.tagName === "TEXTAREA" ||
+        target.tagName === "SELECT" ||
+        target.contentEditable === "true"
+      )) {
+        return;
+      }
+
       if (e.key === "Escape") {
         onClose();
       } else if ((e.key === "v" || e.key === "V") && !e.ctrlKey && !e.metaKey && !e.altKey && !e.shiftKey && !isLoading && log) {

apps/webapp/app/components/logs/LogsRunIdFilter.tsx

@@ -14,7 +14,7 @@ import {
 import { useSearchParams } from "~/hooks/useSearchParam";
 import { FilterMenuProvider } from "~/components/runs/v3/SharedFilters";
 
-const shortcut = { key: "r" };
+const shortcut = { key: "i" };
 
 export function LogsRunIdFilter() {
   const { value } = useSearchParams();

apps/webapp/app/presenters/v3/LogsListPresenter.server.ts

@@ -298,8 +298,7 @@ export class LogsListPresenter extends BasePresenter {
       queryBuilder.where(
         "(lower(message) like {searchPattern: String} OR lower(attributes_text) like {searchPattern: String})",
         {
-          searchPattern: `%${searchTerm.toLowerCase()}%`,
-          statusTerm: searchTerm.toUpperCase(),
+          searchPattern: `%${searchTerm.toLowerCase()}%`
         }
       );
     }

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs.ts

@@ -50,8 +50,11 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
   const period = url.searchParams.get("period") ?? undefined;
   const fromStr = url.searchParams.get("from");
   const toStr = url.searchParams.get("to");
-  const from = fromStr ? parseInt(fromStr, 10) : undefined;
-  const to = toStr ? parseInt(toStr, 10) : undefined;
+  let from = fromStr ? parseInt(fromStr, 10) : undefined;
+  let to = toStr ? parseInt(toStr, 10) : undefined;
+
+  if (Number.isNaN(from)) from = undefined;
+  if (Number.isNaN(to)) to = undefined;
 
   const options = LogsListOptionsSchema.parse({
     userId,

internal-packages/clickhouse/schema/014_add_task_runs_v2_serch_indexes.sql

@@ -7,7 +7,7 @@ ALTER TABLE trigger_dev.task_events_v2
     GRANULARITY 1;
 
 ALTER TABLE trigger_dev.task_events_v2
-    ADD INDEX IF NOT EXISTS message_text_search lower(message)
+    ADD INDEX IF NOT EXISTS idx_message_text_search lower(message)
     TYPE ngrambf_v1(3, 32768, 2, 0)
     GRANULARITY 1;