Skip to content

Commit 8e970f0

Browse files
committed
chore: remove dead getQueueName method, clarify hot path docs
1 parent 48670b6 commit 8e970f0

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

apps/webapp/CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Some services (e.g., `cancelTaskRun.server.ts`, `batchTriggerV3.server.ts`) bran
6161

6262
The `triggerTask.server.ts` service is the **highest-throughput code path** in the system. Every API trigger call goes through it. Keep it fast:
6363

64-
- **Do NOT add database queries** to the trigger path. The only acceptable DB query for task defaults (TTL, etc.) is the single existing `backgroundWorkerTask.findFirst()` call in the queue concern. Piggyback on it instead of adding new queries.
64+
- **Do NOT add database queries** to `triggerTask.server.ts` or `batchTriggerV3.server.ts`. Task defaults (TTL, etc.) are resolved via `backgroundWorkerTask.findFirst()` in the queue concern (`queues.server.ts`) - one query per request, in mutually exclusive branches depending on locked/non-locked path. Piggyback on the existing query instead of adding new ones.
6565
- **Two-stage resolution pattern**: Task metadata is resolved in two stages by design:
6666
1. **Trigger time** (`triggerTask.server.ts`): Only TTL is resolved from task defaults. Everything else uses whatever the caller provides.
6767
2. **Dequeue time** (`dequeueSystem.ts`): Full `BackgroundWorkerTask` is loaded and retry config, machine config, maxDuration, etc. are resolved against task defaults.

apps/webapp/app/runEngine/concerns/queues.server.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,6 @@ export class DefaultQueueManager implements QueueManager {
186186
};
187187
}
188188

189-
async getQueueName(request: TriggerTaskRequest): Promise<string> {
190-
const result = await this.getTaskQueueInfo(request);
191-
return result.queueName;
192-
}
193-
194189
private async getTaskQueueInfo(
195190
request: TriggerTaskRequest
196191
): Promise<{ queueName: string; taskTtl?: string | null }> {

apps/webapp/app/runEngine/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export interface QueueManager {
6262
request: TriggerTaskRequest,
6363
lockedBackgroundWorker?: LockedBackgroundWorker
6464
): Promise<QueueProperties>;
65-
getQueueName(request: TriggerTaskRequest): Promise<string>;
6665
validateQueueLimits(
6766
env: AuthenticatedEnvironment,
6867
queueName: string,

0 commit comments

Comments
 (0)