Added run repository feature flag, allowing passing a default when getting a flag

Author: matt-aitken

apps/webapp/app/v3/featureFlags.server.ts

@@ -1,23 +1,32 @@
 import { z } from "zod";
-import { prisma, PrismaClientOrTransaction } from "~/db.server";
+import { prisma, type PrismaClientOrTransaction } from "~/db.server";
 
 export const FEATURE_FLAG = {
   defaultWorkerInstanceGroupId: "defaultWorkerInstanceGroupId",
+  runsListRepository: "runsListRepository",
 } as const;
 
 const FeatureFlagCatalog = {
   [FEATURE_FLAG.defaultWorkerInstanceGroupId]: z.string(),
+  [FEATURE_FLAG.runsListRepository]: z.enum(["clickhouse", "postgres"]),
 };
 
 type FeatureFlagKey = keyof typeof FeatureFlagCatalog;
 
-export type FlagsOptions = {
-  key: FeatureFlagKey;
+export type FlagsOptions<T extends FeatureFlagKey> = {
+  key: T;
+  defaultValue?: z.infer<(typeof FeatureFlagCatalog)[T]>;
 };
 
 export function makeFlags(_prisma: PrismaClientOrTransaction = prisma) {
-  return async function flags<T extends FeatureFlagKey>(
-    opts: FlagsOptions
+  function flags<T extends FeatureFlagKey>(
+    opts: FlagsOptions<T> & { defaultValue: z.infer<(typeof FeatureFlagCatalog)[T]> }
+  ): Promise<z.infer<(typeof FeatureFlagCatalog)[T]>>;
+  function flags<T extends FeatureFlagKey>(
+    opts: FlagsOptions<T>
+  ): Promise<z.infer<(typeof FeatureFlagCatalog)[T]> | undefined>;
+  async function flags<T extends FeatureFlagKey>(
+    opts: FlagsOptions<T>
   ): Promise<z.infer<(typeof FeatureFlagCatalog)[T]> | undefined> {
     const value = await _prisma.featureFlag.findUnique({
       where: {
@@ -28,16 +37,18 @@ export function makeFlags(_prisma: PrismaClientOrTransaction = prisma) {
     const parsed = FeatureFlagCatalog[opts.key].safeParse(value?.value);
 
     if (!parsed.success) {
-      return;
+      return opts.defaultValue;
     }
 
     return parsed.data;
-  };
+  }
+
+  return flags;
 }
 
 export function makeSetFlags(_prisma: PrismaClientOrTransaction = prisma) {
   return async function setFlags<T extends FeatureFlagKey>(
-    opts: FlagsOptions & { value: z.infer<(typeof FeatureFlagCatalog)[T]> }
+    opts: FlagsOptions<T> & { value: z.infer<(typeof FeatureFlagCatalog)[T]> }
   ): Promise<void> {
     await _prisma.featureFlag.upsert({
       where: {