Skip to content

Commit 4987c17

Browse files
committed
Show truncated run ID instead of run numbers for recent runs
Run numbers will soon get deprecated due to contention issues
1 parent 7b266d9 commit 4987c17

File tree

2 files changed

+17
-24
lines changed

2 files changed

+17
-24
lines changed

apps/webapp/app/presenters/v3/TestTaskPresenter.server.ts

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ export type TestTaskResult =
6363

6464
type RawRun = {
6565
id: string;
66-
number: BigInt;
6766
queue: string;
6867
friendlyId: string;
6968
createdAt: Date;
@@ -82,14 +81,12 @@ type RawRun = {
8281
runTags: string[];
8382
};
8483

85-
export type StandardRun = Omit<RawRun, "number" | "ttl"> & {
86-
number: number;
84+
export type StandardRun = Omit<RawRun, "ttl"> & {
8785
metadata?: string;
8886
ttlSeconds?: number;
8987
};
9088

91-
export type ScheduledRun = Omit<RawRun, "number" | "payload" | "ttl"> & {
92-
number: number;
89+
export type ScheduledRun = Omit<RawRun, "payload" | "ttl"> & {
9390
payload: {
9491
timestamp: Date;
9592
lastTimestamp?: Date;
@@ -186,7 +183,6 @@ export class TestTaskPresenter {
186183
)
187184
SELECT
188185
taskr.id,
189-
taskr.number,
190186
taskr."queue",
191187
taskr."friendlyId",
192188
taskr."taskIdentifier",
@@ -233,19 +229,17 @@ export class TestTaskPresenter {
233229
: undefined,
234230
task: taskWithEnvironment,
235231
runs: await Promise.all(
236-
latestRuns.map(async (r) => {
237-
const number = Number(r.number);
238-
239-
return {
240-
...r,
241-
number,
242-
payload: await prettyPrintPacket(r.payload, r.payloadType),
243-
metadata: r.seedMetadata
244-
? await prettyPrintPacket(r.seedMetadata, r.seedMetadataType)
245-
: undefined,
246-
ttlSeconds: r.ttl ? parse(r.ttl, "s") ?? undefined : undefined,
247-
} satisfies StandardRun;
248-
})
232+
latestRuns.map(
233+
async (r) =>
234+
({
235+
...r,
236+
payload: await prettyPrintPacket(r.payload, r.payloadType),
237+
metadata: r.seedMetadata
238+
? await prettyPrintPacket(r.seedMetadata, r.seedMetadataType)
239+
: undefined,
240+
ttlSeconds: r.ttl ? parse(r.ttl, "s") ?? undefined : undefined,
241+
} satisfies StandardRun)
242+
)
249243
),
250244
latestVersions,
251245
},
@@ -263,14 +257,11 @@ export class TestTaskPresenter {
263257
runs: (
264258
await Promise.all(
265259
latestRuns.map(async (r) => {
266-
const number = Number(r.number);
267-
268260
const payload = await getScheduleTaskRunPayload(r);
269261

270262
if (payload.success) {
271263
return {
272264
...r,
273-
number,
274265
payload: payload.data,
275266
ttlSeconds: r.ttl ? parse(r.ttl, "s") ?? undefined : undefined,
276267
} satisfies ScheduledRun;

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,10 @@ function StandardTaskForm({
425425
<Paragraph variant="small">
426426
<DateTime date={run.createdAt} showTooltip={false} />
427427
</Paragraph>
428-
<div className="flex items-center gap-1 text-xs text-text-dimmed">
429-
<div>Run #{run.number}</div>
428+
<div className="flex items-center gap-2 text-xs text-text-dimmed">
429+
<div>
430+
Run <span className="font-mono">{run.friendlyId.slice(-8)}</span>
431+
</div>
430432
<TaskRunStatusCombo status={run.status} />
431433
</div>
432434
</div>

0 commit comments

Comments
 (0)