fix: use correct language to store questions, closes #3453

Author: thorsten

phpmyfaq/src/phpMyFAQ/Controller/Api/QuestionController.php

@@ -114,6 +114,7 @@ public function create(Request $request): JsonResponse
             ->setEmail($email)
             ->setCategoryId($categoryId)
             ->setQuestion($question)
+            ->setLanguage($this->configuration->getLanguage()->getLanguage())
             ->setIsVisible($visibility === 'Y');
 
         $questionObject = new Question($this->configuration);

phpmyfaq/src/phpMyFAQ/Controller/Frontend/QuestionController.php

@@ -32,7 +32,6 @@
 use phpMyFAQ\StopWords;
 use phpMyFAQ\Strings;
 use phpMyFAQ\Translation;
-use phpMyFAQ\User\CurrentUser;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -65,6 +64,7 @@ public function create(Request $request): JsonResponse
         $author = trim((string) Filter::filterVar($data->name, FILTER_SANITIZE_SPECIAL_CHARS));
         $email = trim((string) Filter::filterVar($data->email, FILTER_VALIDATE_EMAIL));
         $selectedCategory = isset($data->category) ? Filter::filterVar($data->category, FILTER_VALIDATE_INT) : false;
+        $language = trim((string) Filter::filterVar($data->lang, FILTER_SANITIZE_SPECIAL_CHARS));
         $userQuestion = trim(strip_tags((string) $data->question));
         $save = Filter::filterVar($data->save ?? 0, FILTER_VALIDATE_INT);
         $storeNow = Filter::filterVar($data->store ?? 'not', FILTER_SANITIZE_SPECIAL_CHARS);
@@ -95,6 +95,7 @@ public function create(Request $request): JsonResponse
                 ->setUsername($author)
                 ->setEmail($email)
                 ->setCategoryId($selectedCategory)
+                ->setLanguage($language)
                 ->setQuestion(Strings::htmlentities($userQuestion))
                 ->setIsVisible($visibility === 'Y');
 

phpmyfaq/src/phpMyFAQ/Question.php

@@ -50,7 +50,7 @@ public function add(QuestionEntity $questionData): bool
             (%d, '%s', '%s', '%s', %d, '%s', '%s', '%s', %d)",
             Database::getTablePrefix(),
             $this->configuration->getDb()->nextId(Database::getTablePrefix() . 'faqquestions', 'id'),
-            $this->configuration->getLanguage()->getLanguage(),
+            $this->configuration->getDb()->escape($questionData->getLanguage()),
             $this->configuration->getDb()->escape($questionData->getUsername()),
             $this->configuration->getDb()->escape($questionData->getEmail()),
             $questionData->getCategoryId(),

tests/phpMyFAQ/QuestionTest.php

@@ -36,6 +36,7 @@ public function testAdd(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->assertTrue($this->question->add($questionData));
@@ -49,6 +50,7 @@ public function testDelete(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->question->add($questionData);
@@ -63,6 +65,7 @@ public function testGet(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->question->add($questionData);
@@ -80,6 +83,7 @@ public function testGetAll(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->question->add($questionData);
@@ -90,6 +94,7 @@ public function testGetAll(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->question->add($questionData);
@@ -108,6 +113,7 @@ public function testGetVisibility(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(false);
 
         $this->question->add($questionData);
@@ -123,6 +129,7 @@ public function testSetVisibility(): void
             ->setEmail('test@example.org')
             ->setCategoryId(1)
             ->setQuestion('Test question')
+            ->setLanguage('en')
             ->setIsVisible(true);
 
         $this->question->add($questionData);