fix: added fallback values if question data is empty

Author: thorsten

phpmyfaq/.env.example

@@ -1,8 +1,8 @@
-# Debug Configuration
+# Debug Configuration, valid values are true or false
 DEBUG=false
 DEBUG_LOG_QUERIES=false
 
-# Application Configuration
+# Application Configuration, valid values are production, development, or testing
 APP_ENV=development
 
 # ElasticSearch and OpenSearch Configuration

phpmyfaq/src/phpMyFAQ/Controller/Administration/FaqController.php

@@ -32,6 +32,7 @@
 use phpMyFAQ\Filter;
 use phpMyFAQ\Helper\LanguageHelper;
 use phpMyFAQ\Link;
+use phpMyFAQ\Question;
 use phpMyFAQ\Session\Token;
 use phpMyFAQ\Translation;
 use phpMyFAQ\Twig\Extensions\FormatBytesTwigExtension;
@@ -537,20 +538,22 @@ public function answer(Request $request): Response
             'admin-answer-question ' . $questionId,
         );
 
-        $question = $this->container->get(id: 'phpmyfaq.question')->get($questionId);
+        /** @var Question $question */
+        $question = $this->container->get(id: 'phpmyfaq.question');
+        $questionData = $question->get($questionId);
 
         $faqData = [
             'id' => 0,
             'lang' => $this->configuration->getLanguage()->getLanguage(),
-            'title' => $question['question'],
+            'title' => $questionData['question'] ?? '',
             'revision_id' => 0,
             'author' => $this->currentUser->getUserData('display_name'),
             'email' => $this->currentUser->getUserData('email'),
             'comment' => $this->configuration->get(item: 'records.defaultAllowComments') ? 'checked' : null,
         ];
 
         $categories = [
-            'category_id' => $question['category_id'],
+            'category_id' => $questionData['category_id'] ?? [],
             'category_lang' => $faqLanguage,
         ];
 
@@ -568,8 +571,8 @@ public function answer(Request $request): Response
             'faqRevisionId' => 0,
             'faqData' => $faqData,
             'openQuestionId' => 0,
-            'notifyUser' => $question['username'],
-            'notifyEmail' => $question['email'],
+            'notifyUser' => $questionData['username'] ?? $this->currentUser->getUserData('display_name'),
+            'notifyEmail' => $questionData['email'] ?? $this->currentUser->getUserData('email'),
             'categoryOptions' => $categoryHelper->renderOptions($categories),
             'languageOptions' => LanguageHelper::renderSelectLanguage($faqLanguage, false, [], 'lang'),
             'attachments' => [],