chore: Lint on build (#806)

arcoraven · web-flow · commit 04fdca0e4f80 · 2024-12-10T19:02:33.000+08:00
* chore: Biome linter fixes

* chore: Add lint on build
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/.github/workflows/build-image-tag.yml b/.github/workflows/build-image-tag.yml
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,4 +1,4 @@
-name: Check Build
+name: Build
 
 on: pull_request
 
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -0,0 +1,24 @@
+name: Lint
+
+on: pull_request
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+        with:
+          ref: ${{ github.ref }}
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: "18"
+          cache: "yarn"
+  
+      - name: Install dependencies
+        run: yarn install
+
+      - name: Run lint
+        run: yarn lint
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
diff --git a/.gitignore b/.gitignore
@@ -54,9 +54,6 @@ web_modules/
 # Optional npm cache directory
 .npm
 
-# Optional eslint cache
-.eslintcache
-
 # Optional stylelint cache
 .stylelintcache
 
diff --git a/package.json b/package.json
@@ -21,9 +21,9 @@
     "start:run": "node --experimental-specifier-resolution=node ./dist/index.js",
     "start:docker": "docker compose --profile engine --env-file ./.env up --remove-orphans",
     "start:docker-force-build": "docker compose --profile engine --env-file ./.env up --remove-orphans --build",
-    "lint:fix": "eslint --fix 'src/**/*.ts'",
     "test:unit": "vitest",
     "test:coverage": "vitest run --coverage",
+    "lint": "yarn biome lint",
     "copy-files": "cp -r ./src/prisma ./dist/"
   },
   "dependencies": {
@@ -82,21 +82,12 @@
     "@types/pg": "^8.6.6",
     "@types/uuid": "^9.0.1",
     "@types/ws": "^8.5.5",
-    "@typescript-eslint/eslint-plugin": "^5.55.0",
-    "@typescript-eslint/parser": "^5.55.0",
     "@vitest/coverage-v8": "^2.0.3",
-    "eslint": "^9.3.0",
-    "eslint-config-prettier": "^8.7.0",
     "openapi-typescript-codegen": "^0.25.0",
-    "prettier": "^2.8.7",
     "prool": "^0.0.16",
     "typescript": "^5.1.3",
     "vitest": "^2.0.3"
   },
-  "lint-staged": {
-    "*.{js,ts}": "eslint --cache --fix",
-    "*.{js,ts,md}": "prettier --write"
-  },
   "prisma": {
     "schema": "./src/prisma/schema.prisma"
   },
diff --git a/src/server/routes/admin/nonces.ts b/src/server/routes/admin/nonces.ts
@@ -91,7 +91,7 @@ export async function getNonceDetailsRoute(fastify: FastifyInstance) {
       const { walletAddress, chain } = request.query;
       const result = await getNonceDetails({
         walletAddress: walletAddress ? getAddress(walletAddress) : undefined,
-        chainId: chain ? parseInt(chain) : undefined,
+        chainId: chain ? Number.parseInt(chain) : undefined,
       });
 
       reply.status(StatusCodes.OK).send({
@@ -144,12 +144,12 @@ export const getNonceDetails = async ({
       walletAddress: key.walletAddress,
       chainId: key.chainId,
       onchainNonce: onchainNonces[index],
-      lastUsedNonce: parseInt(lastUsedNonceResult[1] as string) ?? 0,
+      lastUsedNonce: Number.parseInt(lastUsedNonceResult[1] as string) ?? 0,
       sentNonces: (sentNoncesResult[1] as string[])
-        .map((nonce) => parseInt(nonce))
+        .map((nonce) => Number.parseInt(nonce))
         .sort((a, b) => b - a),
       recycledNonces: (recycledNoncesResult[1] as string[])
-        .map((nonce) => parseInt(nonce))
+        .map((nonce) => Number.parseInt(nonce))
         .sort((a, b) => b - a),
     };
   });
diff --git a/src/server/routes/contract/extensions/erc721/write/set-claim-conditions.ts b/src/server/routes/contract/extensions/erc721/write/set-claim-conditions.ts
@@ -78,8 +78,8 @@ export async function erc721SetClaimConditions(fastify: FastifyInstance) {
         return {
           ...item,
           startTime: item.startTime
-            ? isUnixEpochTimestamp(parseInt(item.startTime.toString()))
-              ? new Date(parseInt(item.startTime.toString()) * 1000)
+            ? isUnixEpochTimestamp(Number.parseInt(item.startTime.toString()))
+              ? new Date(Number.parseInt(item.startTime.toString()) * 1000)
               : new Date(item.startTime)
             : undefined,
         };
diff --git a/src/server/routes/contract/extensions/erc721/write/update-claim-conditions.ts b/src/server/routes/contract/extensions/erc721/write/update-claim-conditions.ts
@@ -80,10 +80,11 @@ export async function erc721UpdateClaimConditions(fastify: FastifyInstance) {
         ...claimConditionInput,
         startTime: claimConditionInput.startTime
           ? isUnixEpochTimestamp(
-              parseInt(claimConditionInput.startTime.toString()),
+              Number.parseInt(claimConditionInput.startTime.toString()),
             )
             ? new Date(
-                parseInt(claimConditionInput.startTime.toString()) * 1000,
+                Number.parseInt(claimConditionInput.startTime.toString()) *
+                  1000,
               )
             : new Date(claimConditionInput.startTime)
           : undefined,
diff --git a/src/shared/db/relayer/get-relayer-by-id.ts b/src/shared/db/relayer/get-relayer-by-id.ts
@@ -17,7 +17,7 @@ export const getRelayerById = async ({ id }: GetRelayerByIdParams) => {
 
   return {
     ...relayer,
-    chainId: parseInt(relayer.chainId),
+    chainId: Number.parseInt(relayer.chainId),
     allowedContracts: relayer.allowedContracts
       ? (JSON.parse(relayer.allowedContracts).map((contractAddress: string) =>
           contractAddress.toLowerCase(),
diff --git a/src/shared/db/wallets/nonce-map.ts b/src/shared/db/wallets/nonce-map.ts
@@ -53,7 +53,7 @@ export const getNonceMap = async (args: {
   for (let i = 0; i < elementsWithScores.length; i += 2) {
     result.push({
       queueId: elementsWithScores[i],
-      nonce: parseInt(elementsWithScores[i + 1]),
+      nonce: Number.parseInt(elementsWithScores[i + 1]),
     });
   }
   return result;
@@ -73,7 +73,7 @@ export const pruneNonceMaps = async () => {
   let numDeleted = 0;
   for (const [error, result] of results) {
     if (!error) {
-      numDeleted += parseInt(result as string);
+      numDeleted += Number.parseInt(result as string);
     }
   }
   return numDeleted;
diff --git a/src/shared/utils/cron/is-valid-cron.ts b/src/shared/utils/cron/is-valid-cron.ts
@@ -28,7 +28,7 @@ export const isValidCron = (input: string): boolean => {
 
   let parsedSecondsValue: number | null = null;
   if (seconds.startsWith("*/")) {
-    parsedSecondsValue = parseInt(seconds.split("/")[1]);
+    parsedSecondsValue = Number.parseInt(seconds.split("/")[1]);
   }
 
   // Check for specific invalid patterns in seconds field
@@ -66,7 +66,7 @@ const checkCronFieldInterval = (
   fieldName: string,
 ) => {
   if (field.startsWith("*/")) {
-    const parsedValue = parseInt(field.split("/")[1]);
+    const parsedValue = Number.parseInt(field.split("/")[1]);
     if (parsedValue < minValue || parsedValue > maxValue) {
       throw createCustomError(
         `Invalid cron expression. ${fieldName} must be between ${minValue} and ${maxValue} when using an interval.`,
diff --git a/src/worker/queues/process-event-logs-queue.ts b/src/worker/queues/process-event-logs-queue.ts
@@ -36,7 +36,7 @@ export class ProcessEventsLogQueue {
     // This backoff attempts at intervals:
     // 30s, 1m, 2m, 4m, 8m, 16m, 32m, ~1h, ~2h, ~4h
     for (let i = 0; i < requeryDelays.length; i++) {
-      const delay = parseInt(requeryDelays[i]) * 1000;
+      const delay = Number.parseInt(requeryDelays[i]) * 1000;
       const attempts = i === requeryDelays.length - 1 ? 10 : 0;
       await this.q.add(jobName, serialized, {
         delay,
diff --git a/src/worker/queues/process-transaction-receipts-queue.ts b/src/worker/queues/process-transaction-receipts-queue.ts
@@ -36,7 +36,7 @@ export class ProcessTransactionReceiptsQueue {
     // This backoff attempts at intervals:
     // 30s, 1m, 2m, 4m, 8m, 16m, 32m, ~1h, ~2h, ~4h
     for (let i = 0; i < requeryDelays.length; i++) {
-      const delay = parseInt(requeryDelays[i]) * 1000;
+      const delay = Number.parseInt(requeryDelays[i]) * 1000;
       const attempts = i === requeryDelays.length - 1 ? 10 : 0;
       await this.q.add(jobName, serialized, {
         delay,
diff --git a/src/worker/tasks/cancel-recycled-nonces-worker.ts b/src/worker/tasks/cancel-recycled-nonces-worker.ts
@@ -68,7 +68,7 @@ const handler: Processor<any, void, string> = async (job: Job<string>) => {
 const fromRecycledNoncesKey = (key: string) => {
   const [_, chainId, walletAddress] = key.split(":");
   return {
-    chainId: parseInt(chainId),
+    chainId: Number.parseInt(chainId),
     walletAddress: walletAddress as Address,
   };
 };
@@ -89,5 +89,5 @@ const getAndDeleteRecycledNonces = async (key: string) => {
     throw new Error(`Error getting members of ${key}: ${error}`);
   }
   // No need to sort here as ZRANGE returns elements in ascending order
-  return (nonces as string[]).map((v) => parseInt(v));
+  return (nonces as string[]).map((v) => Number.parseInt(v));
 };
diff --git a/tests/e2e/.gitignore b/tests/e2e/.gitignore
@@ -71,9 +71,6 @@ web_modules/
 
 .npm
 
-# Optional eslint cache
-
-.eslintcache
 
 # Optional stylelint cache
 
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: Check Build`
	`1`	`+name: Build`
`2`	`2`
`3`	`3`	`on: pull_request`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -80,10 +80,11 @@ export async function erc721UpdateClaimConditions(fastify: FastifyInstance) {`
`80`	`80`	`...claimConditionInput,`
`81`	`81`	`startTime: claimConditionInput.startTime`
`82`	`82`	`? isUnixEpochTimestamp(`
`83`		`- parseInt(claimConditionInput.startTime.toString()),`
	`83`	`+ Number.parseInt(claimConditionInput.startTime.toString()),`
`84`	`84`	`)`
`85`	`85`	`? new Date(`
`86`		`- parseInt(claimConditionInput.startTime.toString()) * 1000,`
	`86`	`+ Number.parseInt(claimConditionInput.startTime.toString()) *`
	`87`	`+ 1000,`
`87`	`88`	`)`
`88`	`89`	`: new Date(claimConditionInput.startTime)`
`89`	`90`	`: undefined,`