Skip to content

audio: copier: avoid serializing uninitialized stream position to host #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abonislawski wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

audio: copier: avoid serializing uninitialized stream position to host #10859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/audio/copier/copier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,8 +930,9 @@ __cold static int copier_get_configuration(struct processing_module *mod,
struct copier_data *cd = module_get_private_data(mod);
struct ipc4_llp_reading_extended llp_ext;
struct comp_dev *dev = mod->dev;
struct sof_ipc_stream_posn posn;
struct sof_ipc_stream_posn posn = { 0 };
struct ipc4_llp_reading llp;
int ret;

assert_can_be_cold();

Expand Down Expand Up @@ -961,7 +962,9 @@ __cold static int copier_get_configuration(struct processing_module *mod,
}

/* get llp from dai */
comp_position(dev, &posn);
ret = comp_position(dev, &posn);
if (ret < 0)
return ret;
Comment thread
abonislawski marked this conversation as resolved.

convert_u64_to_u32s(posn.comp_posn, &llp.llp_l, &llp.llp_u);
convert_u64_to_u32s(posn.wallclock, &llp.wclk_l, &llp.wclk_u);
Expand Down Expand Up @@ -991,7 +994,9 @@ __cold static int copier_get_configuration(struct processing_module *mod,
}

/* get llp from dai */
comp_position(dev, &posn);
ret = comp_position(dev, &posn);
if (ret < 0)
return ret;
Comment thread
abonislawski marked this conversation as resolved.

convert_u64_to_u32s(posn.comp_posn, &llp_ext.llp_reading.llp_l,
&llp_ext.llp_reading.llp_u);
Expand Down
Loading