acp: add TDM DAI and DMA support for ACP 7.0 by Sivasubramanian678 · Pull Request #10761 · thesofproject/sof

Sivasubramanian678 · 2026-05-11T03:34:23Z

Add TDM DAI and DMA support for the AMD ACP
7.0 platform with three instances: HS, SP, and BT.

sofci · 2026-05-11T03:36:11Z

Can one of the admins verify this patch?

reply test this please to run this test once

Sivasubramanian678 · 2026-05-11T03:37:25Z

Dependency: This PR depends on zephyrproject-rtos/zephyr#108314 for native Zephyr ACP 7.0 TDM driver enablement.

lyakh · 2026-05-11T06:04:52Z

+				} else {
+					tdm_ctx = (struct tdm_context *)tdm_data->dai_index_ptr;
+				}
+				tdm_ctx->index = dd->dai->index;


indentation too deep

lyakh · 2026-05-11T06:08:23Z

+				struct tdm_context *tdm_ctx;
+				if (!tdm_data->dai_index_ptr) {
+					tdm_ctx = rzalloc(SOF_MEM_FLAG_USER | SOF_MEM_FLAG_COHERENT,
+							  sizeof(*tdm_ctx));


does it have to be uncached because it's accessed from different contexts? Maybe you need a comment for that

lgirdwood · 2026-05-11T15:35:17Z

Will run CI.

lgirdwood · 2026-05-11T15:35:23Z

test this please

lgirdwood

Check now added for memory alloc. @lyakh fyi.

lgirdwood · 2026-05-12T15:22:05Z

@Sivasubramanian678 pls see CI, lots of build failures showing

/__w/sof/sof/sof/src/audio/dai-zephyr.c: In function 'dai_set_config':
/__w/sof/sof/sof/src/audio/dai-zephyr.c:204:28: error: 'DAI_AMD_TDM' undeclared (first use in this function); did you mean 'DAI_AMD_SDW'?
  204 |                 cfg.type = DAI_AMD_TDM;
      |                            ^~~~~~~~~~~
      |                            DAI_AMD_SDW
/__w/sof/sof/sof/src/audio/dai-zephyr.c:204:28: note: each undeclared identifier is reported only once for each function it appears in
[364/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/notification_pool.c.obj
[365/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc-common.c.obj
[366/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc4/handler-user.c.obj
[367/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc-helper.c.obj
[368/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc4/helper.c.obj

Sivasubramanian678 · 2026-05-13T05:05:43Z

@Sivasubramanian678 pls see CI, lots of build failures showing

/__w/sof/sof/sof/src/audio/dai-zephyr.c: In function 'dai_set_config':
/__w/sof/sof/sof/src/audio/dai-zephyr.c:204:28: error: 'DAI_AMD_TDM' undeclared (first use in this function); did you mean 'DAI_AMD_SDW'?
  204 |                 cfg.type = DAI_AMD_TDM;
      |                            ^~~~~~~~~~~
      |                            DAI_AMD_SDW
/__w/sof/sof/sof/src/audio/dai-zephyr.c:204:28: note: each undeclared identifier is reported only once for each function it appears in
[364/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/notification_pool.c.obj
[365/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc-common.c.obj
[366/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc4/handler-user.c.obj
[367/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc-helper.c.obj
[368/465] Building C object modules/sof/CMakeFiles/modules_sof.dir/__w/sof/sof/sof/src/ipc/ipc4/helper.c.obj

Dependency: This PR depends on zephyrproject-rtos/zephyr#108314 for native Zephyr ACP 7.0 TDM driver enablement. So we have to wait till zephyr PR's merge.

lyakh · 2026-05-29T07:53:08Z

Check now added for memory alloc. @lyakh fyi.

oh, ouch... how have I missed it?? Sorry! Shouldn't happen actually...

kv2019i · 2026-06-01T17:32:26Z

This now hits same failure on NXP IMX95 as hits previous attempt to upgrade Zephyr (see latest status in #10765 (comment) ).

Sivasubramanian678 · 2026-06-03T05:36:14Z

This now hits same failure on NXP IMX95 as hits previous attempt to upgrade Zephyr (see latest status in #10765 (comment) ).

Thanks for the update, @kv2019i . Could you please let me know what I should do from my side to proceed?

kv2019i · 2026-06-03T16:57:17Z

Thanks for the update, @kv2019i . Could you please let me know what I should do from my side to proceed?

We are depending on zephyrproject-rtos/zephyr#109474 and updating the PR to include that in the Zephyr update. @dbaluta @LaurentiuM1234 any takes on this, can we help to expedite this? Or if this take more time, ok to proceed and break imx95 for a moment...?

Add TDM DAI and DMA support for the AMD ACP 7.0 platform with three instances: HS, SP, and BT. Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>

Sivasubramanian678 · 2026-06-09T05:55:35Z

Thanks for the update, @kv2019i . Could you please let me know what I should do from my side to proceed?

We are depending on zephyrproject-rtos/zephyr#109474 and updating the PR to include that in the Zephyr update. @dbaluta @LaurentiuM1234 any takes on this, can we help to expedite this? Or if this take more time, ok to proceed and break imx95 for a moment...?

Hi @kv2019i, the mentioned commit has now been merged. Could you please let me know if any updates are required from my side to ensure that the i.MX95 CI does not fail?

kv2019i · 2026-06-09T09:22:45Z

@Sivasubramanian678 Can you update your PR and take a newer commit from Zephyr main (that includes the now merged fix to imx95) and resubmit. CI should pass now and we can proceed to merge.

Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>

Sivasubramanian678 · 2026-06-09T12:37:25Z

@Sivasubramanian678 Can you update your PR and take a newer commit from Zephyr main (that includes the now merged fix to imx95) and resubmit. CI should pass now and we can proceed to merge.

Hi @kv2019i, I have updated my PR with the latest commit from Zephyr main that includes the i.MX95 fix, as suggested. However, I’m still seeing the i.MX95 CI failure. Could you please help check if anything else might be missing from my side.

kv2019i · 2026-06-09T13:20:04Z

@thesofproject/nxp can you check? imx95 build seems to still fail. The error is now different than previously:

https://github.com/thesofproject/sof/actions/runs/27205719796/job/80320892865?pr=10761

zephyr/drivers/dma/CMakeFiles/drivers__dma.dir/dma_mcux_edma.c.obj -c /__w/sof/sof/zephyr/drivers/dma/dma_mcux_edma.c
/__w/sof/sof/zephyr/drivers/dma/dma_mcux_edma.c:1225:2: error: #error Unexpected or disallowed cache situation for dma descriptors
 1225 | #error Unexpected or disallowed cache situation for dma descriptors

Sivasubramanian678 requested review from abonislawski, dbaluta, iuliana-prodan, kv2019i, lbetlej, lgirdwood, lyakh, mmaka1, pblaszko, plbossart and tmleman as code owners May 11, 2026 03:34

lyakh reviewed May 11, 2026

View reviewed changes

Sivasubramanian678 force-pushed the main branch from f49d516 to f4dfeef Compare May 11, 2026 09:11

Sivasubramanian678 requested a review from lyakh May 11, 2026 10:33

lyakh requested changes May 12, 2026

View reviewed changes

Comment thread src/ipc/ipc3/dai.c

Sivasubramanian678 force-pushed the main branch from f4dfeef to 5fc4360 Compare May 12, 2026 09:07

Sivasubramanian678 requested a review from lyakh May 12, 2026 09:22

lgirdwood approved these changes May 12, 2026

View reviewed changes

bhiregoudar self-requested a review May 12, 2026 14:27

bhiregoudar approved these changes May 12, 2026

View reviewed changes

Sivasubramanian678 force-pushed the main branch from 5fc4360 to 38270a4 Compare May 28, 2026 11:57

lyakh approved these changes May 29, 2026

View reviewed changes

acp: add TDM DAI and DMA support for ACP 7.0

70a6443

Add TDM DAI and DMA support for the AMD ACP 7.0 platform with three instances: HS, SP, and BT. Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>

Sivasubramanian678 force-pushed the main branch from 9272555 to 54c444d Compare June 9, 2026 05:30

Sivasubramanian678 force-pushed the main branch from 54c444d to 3cef5b0 Compare June 9, 2026 11:24

west.yml: update zephyr to 68d73c0906d

632281c

Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>

Sivasubramanian678 force-pushed the main branch from 3cef5b0 to 632281c Compare June 9, 2026 12:21

Conversation

Sivasubramanian678 commented May 11, 2026

Uh oh!

sofci commented May 11, 2026

Uh oh!

Sivasubramanian678 commented May 11, 2026

Uh oh!

lyakh May 11, 2026

Choose a reason for hiding this comment

Uh oh!

lyakh May 11, 2026

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented May 11, 2026

Uh oh!

lgirdwood commented May 11, 2026

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented May 12, 2026

Uh oh!

Sivasubramanian678 commented May 13, 2026

Uh oh!

lyakh commented May 29, 2026

Uh oh!

kv2019i commented Jun 1, 2026

Uh oh!

Sivasubramanian678 commented Jun 3, 2026

Uh oh!

kv2019i commented Jun 3, 2026

Uh oh!

Sivasubramanian678 commented Jun 9, 2026

Uh oh!

kv2019i commented Jun 9, 2026

Uh oh!

Sivasubramanian678 commented Jun 9, 2026

Uh oh!

kv2019i commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants