rimage: toml_utils: fix errno handling in parse_uint32_hex_key

abonislawski · abonislawski · commit d015d5754ae4 · 2025-09-22T11:34:47.000+02:00
Fix errno handling

Signed-off-by: Adrian Bonislawski &lt;adrian.bonislawski@intel.com&gt;#
diff --git a/tools/rimage/src/toml_utils.c b/tools/rimage/src/toml_utils.c
@@ -151,11 +151,12 @@ uint32_t parse_uint32_hex_key(const toml_table_t *table, struct parse_ctx *ctx,
 		*error = err_key_parse(key, NULL);
 		return UINT32_MAX;
 	}
+	errno = 0;
 	val = strtoul(temp_s, 0, 0);
 
 	free(temp_s);
 	/* assert parsing success and value is within uint32_t range */
-	if (errno < 0) {
+	if (errno != 0) {
 		*error = err_key_parse(key, "can't convert hex value");
 		return UINT32_MAX;
 	}

Original file line number	Diff line number	Diff line change
`@@ -151,11 +151,12 @@ uint32_t parse_uint32_hex_key(const toml_table_t table, struct parse_ctx ctx,`
`151`	`151`	`*error = err_key_parse(key, NULL);`
`152`	`152`	`return UINT32_MAX;`
`153`	`153`	`}`
	`154`	`+ errno = 0;`
`154`	`155`	`val = strtoul(temp_s, 0, 0);`
`155`	`156`
`156`	`157`	`free(temp_s);`
`157`	`158`	`/* assert parsing success and value is within uint32_t range */`
`158`		`- if (errno < 0) {`
	`159`	`+ if (errno != 0) {`
`159`	`160`	`*error = err_key_parse(key, "can't convert hex value");`
`160`	`161`	`return UINT32_MAX;`
`161`	`162`	`}`