use RTIO to signal DP audio and IPCs

lyakh · lyakh · commit 61d69193c0f9 · 2025-08-15T10:43:48.000+02:00
We should be able to run DP threads in user-space mode, for this we
need to move audio and IPC signalling to RTIO.

Signed-off-by: Guennadi Liakhovetski &lt;guennadi.liakhovetski@linux.intel.com&gt;
diff --git a/app/boards/intel_adsp_ace15_mtpm.conf b/app/boards/intel_adsp_ace15_mtpm.conf
@@ -83,6 +83,7 @@ CONFIG_WATCHDOG=y
 CONFIG_TIMESLICE_PER_THREAD=y
 CONFIG_THREAD_RUNTIME_STATS=y
 CONFIG_SCHED_THREAD_USAGE=y
+CONFIG_RTIO=y
 
 # Zephyr / device drivers
 CONFIG_CLOCK_CONTROL=y
diff --git a/app/boards/intel_adsp_ace20_lnl.conf b/app/boards/intel_adsp_ace20_lnl.conf
@@ -63,6 +63,7 @@ CONFIG_LLEXT_STORAGE_WRITABLE=y
 CONFIG_LLEXT_EXPERIMENTAL=y
 CONFIG_MODULES=y
 CONFIG_TIMING_FUNCTIONS=y
+CONFIG_RTIO=y
 
 # Zephyr / device drivers
 CONFIG_CLOCK_CONTROL=y
diff --git a/app/boards/intel_adsp_ace30_ptl.conf b/app/boards/intel_adsp_ace30_ptl.conf
@@ -63,6 +63,7 @@ CONFIG_LLEXT=y
 CONFIG_LLEXT_STORAGE_WRITABLE=y
 CONFIG_LLEXT_EXPERIMENTAL=y
 CONFIG_MODULES=y
+CONFIG_RTIO=y
 
 # Zephyr / device drivers
 CONFIG_CLOCK_CONTROL=y
diff --git a/src/audio/module_adapter/module/generic.c b/src/audio/module_adapter/module/generic.c
@@ -12,8 +12,8 @@
  */
 
 #include <rtos/symbol.h>
-
 #include <sof/audio/module_adapter/module/generic.h>
+#include <sof/schedule/dp_schedule.h>
 
 LOG_MODULE_DECLARE(module_adapter, CONFIG_SOF_LOG_LEVEL);
 
@@ -95,7 +95,11 @@ int module_init(struct processing_module *mod)
 	list_init(&md->memory.mem_list);
 
 	/* Now we can proceed with module specific initialization */
-	ret = interface->init(mod);
+	if (mod->dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP)
+		ret = scheduler_dp_rtio_ipc(mod, SOF_IPC4_MOD_INIT_INSTANCE, NULL);
+	else
+		ret = interface->init(mod);
+
 	if (ret) {
 		comp_err(dev, "module_init() error %d: module specific init failed, comp id %d",
 			 ret, dev_comp_id(dev));
@@ -242,7 +246,23 @@ int module_prepare(struct processing_module *mod,
 		return -EPERM;
 #endif
 	if (ops->prepare) {
-		int ret = ops->prepare(mod, sources, num_of_sources, sinks, num_of_sinks);
+		int ret;
+
+		if (mod->dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) {
+			union scheduler_dp_rtio_ipc_param param = {
+				.pipeline_state = {
+					.trigger_cmd = COMP_TRIGGER_PREPARE,
+					.state = SOF_IPC4_PIPELINE_STATE_RUNNING,
+					.n_sources = num_of_sources,
+					.sources = sources,
+					.n_sinks = num_of_sinks,
+					.sinks = sinks,
+				},
+			};
+			ret = scheduler_dp_rtio_ipc(mod, SOF_IPC4_GLB_SET_PIPELINE_STATE, &param);
+		} else {
+			ret = ops->prepare(mod, sources, num_of_sources, sinks, num_of_sinks);
+		}
 
 		if (ret) {
 			comp_err(dev, "module_prepare() error %d: module specific prepare failed, comp_id %d",
@@ -366,11 +386,17 @@ int module_reset(struct processing_module *mod)
 	if (md->state < MODULE_IDLE)
 		return 0;
 #endif
-	/* cancel task if DP task*/
-	if (mod->dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP && mod->dev->task)
-		schedule_task_cancel(mod->dev->task);
+
 	if (ops->reset) {
-		ret = ops->reset(mod);
+		if (mod->dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) {
+			union scheduler_dp_rtio_ipc_param param = {
+				.pipeline_state.trigger_cmd = COMP_TRIGGER_STOP,
+			};
+			ret = scheduler_dp_rtio_ipc(mod, SOF_IPC4_GLB_SET_PIPELINE_STATE, &param);
+		} else {
+			ret = ops->reset(mod);
+		}
+
 		if (ret) {
 			if (ret != PPL_STATUS_PATH_STOP)
 				comp_err(mod->dev,
@@ -423,7 +449,7 @@ int module_free(struct processing_module *mod)
 	struct module_data *md = &mod->priv;
 	int ret = 0;
 
-	if (ops->free) {
+	if (ops->free && mod->dev->ipc_config.proc_domain != COMP_PROCESSING_DOMAIN_DP) {
 		ret = ops->free(mod);
 		if (ret)
 			comp_warn(mod->dev, "error: %d for %d",
@@ -570,8 +596,16 @@ int module_bind(struct processing_module *mod, struct bind_info *bind_data)
 	if (ret)
 		return ret;
 
-	if (ops->bind)
-		ret = ops->bind(mod, bind_data);
+	if (ops->bind) {
+		if (mod->dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) {
+			union scheduler_dp_rtio_ipc_param param = {
+				.bind_data = bind_data,
+			};
+			ret = scheduler_dp_rtio_ipc(mod, SOF_IPC4_MOD_BIND, &param);
+		} else {
+			ret = ops->bind(mod, bind_data);
+		}
+	}
 
 	return ret;
 }
diff --git a/src/audio/module_adapter/module_adapter.c b/src/audio/module_adapter/module_adapter.c
@@ -18,6 +18,7 @@
 #include <sof/audio/source_api.h>
 #include <sof/audio/audio_buffer.h>
 #include <sof/audio/pipeline.h>
+#include <sof/schedule/dp_schedule.h>
 #include <sof/schedule/ll_schedule_domain.h>
 #include <sof/common.h>
 #include <sof/platform.h>
@@ -1207,8 +1208,17 @@ int module_adapter_trigger(struct comp_dev *dev, int cmd)
 		dev->state = COMP_STATE_ACTIVE;
 		return PPL_STATUS_PATH_STOP;
 	}
-	if (interface->trigger)
+
+	if (interface->trigger) {
+		if (dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) {
+			/* Process DP module's trigger */
+			union scheduler_dp_rtio_ipc_param param = {
+				.pipeline_state.trigger_cmd = cmd,
+			};
+			return scheduler_dp_rtio_ipc(mod, SOF_IPC4_GLB_SET_PIPELINE_STATE, &param);
+		}
 		return interface->trigger(mod, cmd);
+	}
 
 	return module_adapter_set_state(mod, dev, cmd);
 }
@@ -1270,8 +1280,11 @@ void module_adapter_free(struct comp_dev *dev)
 
 	comp_dbg(dev, "start");
 
-	if (dev->task)
+	if (dev->task) {
+		/* Run DP module's .free() method in its thread context */
+		scheduler_dp_rtio_ipc(mod, SOF_IPC4_MOD_DELETE_INSTANCE, NULL);
 		schedule_task_cancel(dev->task);
+	}
 
 	ret = module_free(mod);
 	if (ret)
diff --git a/src/include/module/module/base.h b/src/include/module/module/base.h
@@ -70,6 +70,8 @@ enum module_processing_type {
 	MODULE_PROCESS_TYPE_RAW,
 };
 
+struct rtio_sqe;
+
 /*
  * A pointer to this structure is passed to module API functions (from struct module_interface).
  * This structure should contain only fields that should be available to a module.
@@ -103,6 +105,10 @@ struct processing_module {
 	uint32_t num_of_sources;
 	uint32_t num_of_sinks;
 
+	/* DP module RTIO SQE pointers, used to signal module's DP thread */
+	struct rtio_sqe *ipc_sqe;
+	struct rtio_sqe *audio_sqe;
+
 	/* sink and source handlers for the module */
 	struct sof_sink *sinks[CONFIG_MODULE_MAX_CONNECTIONS];
 	struct sof_source *sources[CONFIG_MODULE_MAX_CONNECTIONS];
diff --git a/src/include/sof/audio/component_ext.h b/src/include/sof/audio/component_ext.h
@@ -46,15 +46,15 @@ static inline void comp_free(struct comp_dev *dev)
 {
 	assert(dev->drv->ops.free);
 
+	dev->drv->ops.free(dev);
+
 	/* free task if shared component or DP task*/
 	if ((dev->is_shared || dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) &&
 	    dev->task) {
 		schedule_task_free(dev->task);
 		rfree(dev->task);
 		dev->task = NULL;
 	}
-
-	dev->drv->ops.free(dev);
 }
 
 /**
diff --git a/src/include/sof/schedule/dp_schedule.h b/src/include/sof/schedule/dp_schedule.h
@@ -13,6 +13,7 @@
 #include <user/trace.h>
 #include <stdint.h>
 #include <ipc4/base_fw.h>
+#include <ipc4/pipeline.h>
 
 struct processing_module;
 
@@ -84,4 +85,22 @@ int scheduler_dp_task_init(struct task **task,
 void scheduler_get_task_info_dp(struct scheduler_props *scheduler_props,
 				uint32_t *data_off_size);
 
+struct bind_info;
+struct sof_source;
+struct sof_sink;
+union scheduler_dp_rtio_ipc_param {
+	struct bind_info *bind_data;
+	struct {
+		unsigned int trigger_cmd;
+		enum ipc4_pipeline_state state;
+		int n_sources;
+		struct sof_source **sources;
+		int n_sinks;
+		struct sof_sink **sinks;
+	} pipeline_state;
+};
+
+int scheduler_dp_rtio_ipc(struct processing_module *pmod, enum sof_ipc4_module_type cmd,
+			  union scheduler_dp_rtio_ipc_param *param);
+
 #endif /* __SOF_SCHEDULE_DP_SCHEDULE_H__ */
diff --git a/src/schedule/zephyr_dp_schedule.c b/src/schedule/zephyr_dp_schedule.c

Original file line number	Diff line number	Diff line change
`@@ -46,15 +46,15 @@ static inline void comp_free(struct comp_dev *dev)`
`46`	`46`	`{`
`47`	`47`	`assert(dev->drv->ops.free);`
`48`	`48`
	`49`	`+ dev->drv->ops.free(dev);`
	`50`	`+`
`49`	`51`	`/* free task if shared component or DP task*/`
`50`	`52`	`if ((dev->is_shared \|\| dev->ipc_config.proc_domain == COMP_PROCESSING_DOMAIN_DP) &&`
`51`	`53`	`dev->task) {`
`52`	`54`	`schedule_task_free(dev->task);`
`53`	`55`	`rfree(dev->task);`
`54`	`56`	`dev->task = NULL;`
`55`	`57`	`}`
`56`		`-`
`57`		`- dev->drv->ops.free(dev);`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/**`