Skip to content

Commit 37ed8d7

Browse files
committed
math: Fix dependencies in filter HiFi selection
The intent of the dependencies on this choice seems to be that they apply only to certain components so the selection should be hidden if they aren't in use. But the logic was wrong: instead of enabling it if any component was enabled that needed it, it would hide the selection unless ALL such components were enabled. Which doesn't build. Fix. (Also I note the comment implies that other kconfigs should probably be in the list too, but not adding them out of conservatism as this is, again, just a hygiene thing.) Signed-off-by: Andy Ross <andyross@google.com>
1 parent 9b37e3f commit 37ed8d7

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/math/Kconfig

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,7 @@ endmenu
128128
# this choice covers math iir, math fir, tdfb, and eqfir, eqiir.
129129
choice "FILTER_SIMD_LEVEL_SELECT"
130130
prompt "choose which SIMD level used for IIR/FIR/TDFB module"
131-
depends on COMP_FIR
132-
depends on COMP_IIR
133-
depends on COMP_TDFB
131+
depends on COMP_FIR || COMP_IIR || COMP_TDFB
134132
default FILTER_HIFI_MAX
135133

136134
config FILTER_HIFI_MAX

0 commit comments

Comments
 (0)