Skip to content

hw: mu: Add mu-write implementation#45

Merged
lgirdwood merged 1 commit into
thesofproject:sof-v4.2from
crazoes:dev
Aug 3, 2020
Merged

hw: mu: Add mu-write implementation#45
lgirdwood merged 1 commit into
thesofproject:sof-v4.2from
crazoes:dev

Conversation

@crazoes

@crazoes crazoes commented Jul 26, 2020

Copy link
Copy Markdown

Add implementation for MU write in order to
communicate with the host.

Signed-off-by: Diana Cretu dianacretu2806@gmail.com
Signed-off-by: Shreeya Patel shreeya.patel23498@gmail.com

@crazoes

crazoes commented Jul 26, 2020

Copy link
Copy Markdown
Author

This extends the work that was being done here earlier - #40

@dbaluta

dbaluta commented Jul 27, 2020

Copy link
Copy Markdown

@crazoes please squash this PR with #40. Thus you will have one big commit with patches squashed. The explanation in this commit is very good, you can keep it at the end of the commit for the squashed commits.

By squash I mean this: https://www.devroom.io/2011/07/05/git-squash-your-latests-commits-into-one/

@crazoes

crazoes commented Jul 27, 2020

Copy link
Copy Markdown
Author

@dbaluta it is already squashed with that PR's commits

@dbaluta

dbaluta commented Jul 27, 2020

Copy link
Copy Markdown

@crazoes Indeed, you are right! thanks!

Comment thread include/hw/adsp/mu.h Outdated
Comment thread hw/adsp/dsp/imx8-mu.c Outdated
Comment thread hw/adsp/dsp/imx8-mu.c Outdated
Comment thread hw/adsp/dsp/imx8-mu.c Outdated
Comment thread hw/adsp/dsp/imx8-mu.c Outdated
Add implementation for MU write in order to communicate with the host.
We add and store reference to both side A and side B's MUs in the adsp
structure because write to control register of side B has to make and
reflect some changes in status register of side A.

Signed-off-by: Diana Cretu <dianacretu2806@gmail.com>
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
@dbaluta

dbaluta commented Jul 27, 2020

Copy link
Copy Markdown

LGTM, @lgirdwood this is good to merge.

@lgirdwood lgirdwood merged commit f71c955 into thesofproject:sof-v4.2 Aug 3, 2020
@marc-hb

marc-hb commented May 13, 2021

Copy link
Copy Markdown

For some reason this is not compatible with Ubuntu 20.04? See thesofproject/sof#4186

@fredoh9

fredoh9 commented May 14, 2021

Copy link
Copy Markdown

This is not working either Ubuntu 18.04 or 20.04. We haven't made sofqemu image for a year. This is first time image update after this commit.

@marc-hb

marc-hb commented May 14, 2021

Copy link
Copy Markdown

Thanks @fredoh9 , sorry for the confusion.

So this commit is the last commit in qemu:master. @fredoh9 how long would it take to upgrade sofqemu to Ubuntu 20.04 and qemu:master~1?

@fredoh9

fredoh9 commented May 14, 2021

Copy link
Copy Markdown

Building sofeqmu is faster then sof image. In my build machine, it takes about 10 min.

@marc-hb

marc-hb commented May 14, 2021

Copy link
Copy Markdown

Hi @fred, I was asking how much effort it would be for you, sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants