Remove floki dep, clean tests

Author: tfwright

mix.exs

@@ -58,7 +58,6 @@ defmodule LiveAdmin.MixProject do
       {:jason, "~> 1.3", only: [:dev, :test]},
       {:ecto_psql_extras, "~> 0.7", only: [:dev, :test]},
       {:faker, "~> 0.17", only: :dev},
-      {:floki, ">= 0.30.0", only: :test},
       {:ex_doc, ">= 0.0.0", only: :dev, runtime: false},
       {:docout, github: "tfwright/docout", branch: "main", runtime: false, only: [:dev, :test]},
       {:dialyxir, "~> 1.2", only: :dev, runtime: false},

mix.lock

@@ -20,7 +20,6 @@
   "faker": {:hex, :faker, "0.17.0", "671019d0652f63aefd8723b72167ecdb284baf7d47ad3a82a15e9b8a6df5d1fa", [:mix], [], "hexpm", "a7d4ad84a93fd25c5f5303510753789fc2433ff241bf3b4144d3f6f291658a6a"},
   "file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"},
   "fine": {:hex, :fine, "0.1.4", "b19a89c1476c7c57afb5f9314aed5960b5bc95d5277de4cb5ee8e1d1616ce379", [:mix], [], "hexpm", "be3324cc454a42d80951cf6023b9954e9ff27c6daa255483b3e8d608670303f5"},
-  "floki": {:hex, :floki, "0.38.0", "62b642386fa3f2f90713f6e231da0fa3256e41ef1089f83b6ceac7a3fd3abf33", [:mix], [], "hexpm", "a5943ee91e93fb2d635b612caf5508e36d37548e84928463ef9dd986f0d1abd9"},
   "gettext": {:hex, :gettext, "0.22.3", "c8273e78db4a0bb6fba7e9f0fd881112f349a3117f7f7c598fa18c66c888e524", [:mix], [{:expo, "~> 0.4.0", [hex: :expo, repo: "hexpm", optional: false]}], "hexpm", "935f23447713954a6866f1bb28c3a878c4c011e802bcd68a726f5e558e4b64bd"},
   "html_entities": {:hex, :html_entities, "0.5.2", "9e47e70598da7de2a9ff6af8758399251db6dbb7eebe2b013f2bbd2515895c3c", [:mix], [], "hexpm", "c53ba390403485615623b9531e97696f076ed415e8d8058b1dbaa28181f4fdcc"},
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},

test/live_admin/components/container_test.exs

@@ -21,23 +21,22 @@ defmodule LiveAdmin.Components.ContainerTest do
 
   describe "home page" do
     setup %{conn: conn} do
-      %{response: conn |> get("/") |> html_response(200)}
-    end
+      {:ok, view, _} = live(conn, "/")
 
-    test "routes live view", %{response: response} do
-      assert response =~ ~s|<title>LiveAdmin</title>|
+      %{view: view}
     end
 
-    test "links to resource", %{response: response} do
-      {:ok, response} = Floki.parse_document(response)
-      assert response |> Floki.find("a[href='/user']") |> Enum.any?()
+    test "links to resource", %{view: view} do
+      assert has_element?(view, "a[href='/user']")
     end
   end
 
   describe "list resource" do
     setup %{conn: conn} do
       user = Repo.insert!(%User{})
+
       {:ok, view, _html} = live(conn, "/user?per=10&page=1&sort-attr=id&sort-dir=asc")
+
       %{view: view, user: user}
     end
 
@@ -76,8 +75,10 @@ defmodule LiveAdmin.Components.ContainerTest do
   describe "list resource with search param not matching any records" do
     setup %{conn: conn} do
       Repo.insert!(%User{name: "Tom"})
-      {:ok, view, html} = live(conn, "/user?per=10&page=1&sort-attr=id&sort-dir=asc&s=fred")
-      %{view: view, response: html}
+
+      {:ok, view, _} = live(conn, "/user?per=10&page=1&sort-attr=id&sort-dir=asc&s=fred")
+
+      %{view: view}
     end
 
     test "shows error", %{view: view} do
@@ -88,7 +89,9 @@ defmodule LiveAdmin.Components.ContainerTest do
   describe "list resource with prefix param" do
     setup %{conn: conn} do
       Repo.insert!(%User{name: "Tom"}, prefix: "alt")
+
       {:ok, view, _} = live(conn, "/user?per=10&page=1&sort-attr=id&sort-dir=asc&prefix=alt")
+
       %{view: view}
     end
 
@@ -116,15 +119,13 @@ defmodule LiveAdmin.Components.ContainerTest do
 
   describe "new parent resource" do
     setup %{conn: conn} do
-      {:ok, view, html} = live(conn, "/user/new")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view}
+      {:ok, view, _} = live(conn, "/user/new")
+
+      %{view: view}
     end
 
-    test "includes castable form field", %{response: response} do
-      assert response
-             |> Floki.find("textarea[name='params[name]']")
-             |> Enum.any?()
+    test "includes castable form field", %{view: view} do
+      assert has_element?(view, "textarea[name='params[name]']")
     end
 
     test "handles form change", %{view: view} do
@@ -156,15 +157,13 @@ defmodule LiveAdmin.Components.ContainerTest do
 
   describe "new child resource" do
     setup %{conn: conn} do
-      {:ok, view, html} = live(conn, "/live_admin_test_post/new")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view}
+      {:ok, view, _} = live(conn, "/live_admin_test_post/new")
+
+      %{view: view}
     end
 
-    test "includes search select field", %{response: response} do
-      assert response
-             |> Floki.find("#params_user_id_search_select")
-             |> Enum.any?()
+    test "includes search select field", %{view: view} do
+      assert has_element?(view, "#params_user_id_search_select")
     end
 
     test "search select responds to focus", %{view: view} do
@@ -177,9 +176,10 @@ defmodule LiveAdmin.Components.ContainerTest do
   describe "edit resource" do
     setup %{conn: conn} do
       user = Repo.insert!(%User{})
-      {:ok, view, html} = live(conn, "/user/edit/#{user.id}")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view, user: user}
+
+      {:ok, view, _} = live(conn, "/user/edit/#{user.id}")
+
+      %{view: view, user: user}
     end
 
     test "updates record on submit", %{view: view, user: user} do
@@ -198,32 +198,28 @@ defmodule LiveAdmin.Components.ContainerTest do
   describe "edit resource with embed" do
     setup %{conn: conn} do
       user = Repo.insert!(%User{settings: %{}})
-      conn = get(conn, "/user/edit/#{user.id}")
-      {:ok, view, html} = live(conn)
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view}
+
+      {:ok, view, _} = live(conn, "/user/edit/#{user.id}")
+
+      %{view: view}
     end
 
-    test "includes embed form field", %{response: response} do
-      assert response
-             |> Floki.find("textarea[name='params[settings][some_option]']")
-             |> Enum.any?()
+    test "includes embed form field", %{view: view} do
+      assert has_element?(view, "textarea[name='params[settings][some_option]']")
     end
   end
 
   describe "edit resource with plural embed with multiple entries" do
     setup %{conn: conn} do
       post = Repo.insert!(%Post{title: "test", previous_versions: [%Version{}, %Version{}]})
-      {:ok, view, html} = live(conn, "/live_admin_test_post/edit/#{post.post_id}")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view}
+
+      {:ok, view, _} = live(conn, "/live_admin_test_post/edit/#{post.post_id}")
+
+      %{view: view}
     end
 
-    test "includes multiple embed fields", %{response: response} do
-      assert 2 =
-               response
-               |> Floki.find(".embed__item")
-               |> Enum.count()
+    test "includes multiple embed fields", %{view: view} do
+      assert has_element?(view, ".embed__item:nth-child(2)")
     end
   end
 
@@ -234,23 +230,23 @@ defmodule LiveAdmin.Components.ContainerTest do
           settings: %{metadata: %{map_key: %{}}}
         })
 
-      {:ok, view, html} = live(conn, "/user/edit/#{user.id}")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, view: view}
+      {:ok, view, _} = live(conn, "/user/edit/#{user.id}")
+
+      %{view: view}
     end
 
-    test "disables field", %{response: response} do
-      assert response
-             |> Floki.find(".resource__action--disabled")
-             |> Enum.any?()
+    test "disables field", %{view: view} do
+      assert has_element?(view, ".resource__action--disabled")
     end
   end
 
   describe "view resource" do
     setup %{conn: conn} do
       user = Repo.insert!(%User{})
-      {:ok, view, html} = live(conn, "/user/#{user.id}")
-      %{response: html, view: view, user: user}
+
+      {:ok, view, _} = live(conn, "/user/#{user.id}")
+
+      %{view: view, user: user}
     end
 
     test "deletes record", %{view: view} do
@@ -265,6 +261,7 @@ defmodule LiveAdmin.Components.ContainerTest do
   describe "view resource with failing action" do
     setup %{conn: conn} do
       user = Repo.insert!(%User{})
+
       {:ok, view, _} = live(conn, "/user/#{user.id}")
 
       view
@@ -283,29 +280,26 @@ defmodule LiveAdmin.Components.ContainerTest do
     setup %{conn: conn} do
       user = Repo.insert!(%User{})
       post = Repo.insert!(%Post{title: "test", user: user})
-      {:ok, _, html} = live(conn, "/live_admin_test_post/#{post.post_id}")
-      {:ok, html} = Floki.parse_document(html)
-      %{response: html, user: user}
+
+      {:ok, view, _} = live(conn, "/live_admin_test_post/#{post.post_id}")
+
+      %{view: view, user: user}
     end
 
-    test "links to user", %{response: response, user: user} do
-      assert response
-             |> Floki.find("a[href='/user/#{user.id}']")
-             |> Enum.any?()
+    test "links to user", %{view: view, user: user} do
+      assert has_element?(view, "a[href='/user/#{user.id}']")
     end
   end
 
   describe "new post with custom string field" do
     setup %{conn: conn} do
-      {:ok, view, html} = live(conn, "/live_admin_test_post/new")
-      {:ok, html} = Floki.parse_document(html)
-      %{view: view, response: html}
+      {:ok, view, _} = live(conn, "/live_admin_test_post/new")
+
+      %{view: view}
     end
 
-    test "includes non-disabled input field for custom string type", %{response: response} do
-      assert response
-             |> Floki.find("textarea[name='params[custom_string_field]']")
-             |> Enum.any?()
+    test "includes non-disabled input field for custom string type", %{view: view} do
+      assert has_element?(view, "textarea[name='params[custom_string_field]']")
     end
 
     test "handles form change with custom string type", %{view: view} do