Skip to content

Commit d9ab854

Browse files
fix: disable whenStable by default (#575)
1 parent 36e0c79 commit d9ab854

File tree

2 files changed

+23
-5
lines changed

2 files changed

+23
-5
lines changed

projects/testing-library/src/tests/zoneless.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ test('renders and interacts with the component', async () => {
8585
expect(valueControl).toHaveTextContent('6');
8686
});
8787

88-
test('renders and interacts with the component with skipWaitForStableOnRender set to true', async () => {
88+
test('renders and interacts with the component with skipDetectChanges set to true', async () => {
8989
const user = userEvent.setup();
90-
await render(FixtureComponent, { skipWaitForStableOnRender: true });
90+
await render(FixtureComponent, { skipDetectChanges: true });
9191

9292
const incrementControl = screen.getByRole('button', { name: '+' });
9393
const decrementControl = screen.getByRole('button', { name: '-' });

projects/testing-library/zoneless/src/public_api.ts

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,20 @@ export interface RenderOptions<Q extends Queries = typeof queries> {
7575
*/
7676
configureTestBed?: (testbed: TestBed) => void;
7777

78+
/**
79+
* @description
80+
* Determines whether `fixture.detectChanges()` is called after the component is rendered.
81+
*
82+
* @default
83+
* true
84+
*
85+
* @example
86+
* await render(AppComponent, {
87+
* skipDetectChanges: false
88+
* })
89+
*/
90+
skipDetectChanges?: boolean;
91+
7892
/**
7993
* @description
8094
* Determines whether `fixture.whenStable()` is called after the component is rendered.
@@ -84,10 +98,10 @@ export interface RenderOptions<Q extends Queries = typeof queries> {
8498
*
8599
* @example
86100
* await render(AppComponent, {
87-
* skipWaitForStableOnRender: false
101+
* waitForStableOnRender: false
88102
* })
89103
*/
90-
skipWaitForStableOnRender?: boolean;
104+
waitForStableOnRender?: boolean;
91105

92106
/**
93107
* @description
@@ -188,7 +202,11 @@ export async function render<ComponentType, WrapperType = ComponentType>(
188202
? await createWrapperFixture(componentOrTemplate, (renderOptions ?? {}) as RenderTemplateOptions<WrapperType>)
189203
: await createComponentFixture(componentOrTemplate, (renderOptions ?? {}) as RenderComponentOptions);
190204

191-
if (renderOptions.skipWaitForStableOnRender !== true) {
205+
if (renderOptions.skipDetectChanges !== true) {
206+
fixture.detectChanges();
207+
}
208+
209+
if (renderOptions.waitForStableOnRender === true) {
192210
await fixture.whenStable();
193211
}
194212

0 commit comments

Comments
 (0)