Rails 7.1 Support Question

[thewatts]

👋 Hey there!

Love all the OSS work that Test Double does - and all of the thought leadership that comes out of the crew.

I was working with a project to update it to 7.1, and the project uses this gem (and it's very helpful!)

I found the issue at hand, specifically - ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33

Not a difficult fix - but I suppose I'm curious if this project is still something actively used by the Test Double team.

If this isn't the recommended path anymore - totally fine, and I'd love to know what the team prefers. If it is, however, I'm more than happy to submit a PR.

Thanks again for all you do!

[simi]

@thewatts any plans to open PR? I have checked and your update works well for our project. Btw. I'm also enjoying using this gem 💪.

[radglob]

Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to ActiveRecord::InternalMetadata are definitely an issue I've run into as well.

If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.

[infews]

PR #12 - 3a1b605 fixes this for 7.1 - but probably won't work with earlier versions.

[thewatts]

Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to ActiveRecord::InternalMetadata are definitely an issue I've run into as well.

If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.

Hey there!

Sorry - I didn't see the notification about your message!

I don't mind taking my code and submitting a PR :)

Hold tight

[thewatts]

@infews added here: #14

[simi]

Any plan to support Rails 7.2 or even Rails 8? Or is it better to off-board this gem from projects?

[infews]

Have you taken a look at https://github.com/kaspth/oaken? It looks like it's overlapping functionality and doesn't fight with (what turned out to be) lower level internals like this gem.

…

On Wed, Jan 8, 2025 at 4:16 PM Josef Šimánek ***@***.***> wrote: Any plan to support Rails 7.2 or even Rails 8? Or is it better to off-board this gem from projects? — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADA4GPBYW7VFW7ZUUINNL2JW5XLAVCNFSM6AAAAABU3A7HSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYHEZTCMZSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- --dwf

[simi]

I'll check, thanks @infews. Meanwhile I did super naive Rails 7.2 support at simi@3da1b62.