Skip to content

Commit 8b3113f

Browse files
committed
Make the tests run correctly with docker
1 parent f3f08cb commit 8b3113f

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

terminusdb_client/tests/integration_tests/conftest.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,19 @@
1212
def is_local_server_running():
1313
"""Check if local TerminusDB server is running at http://127.0.0.1:6363"""
1414
try:
15-
response = requests.get("http://127.0.0.1:6363/api/ok", timeout=2)
16-
return response.status_code == 200
15+
requests.get("http://127.0.0.1:6363/api/ok", timeout=2)
16+
# Any HTTP response means server is running
17+
return True
1718
except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
1819
return False
1920

2021

2122
def is_docker_server_running():
2223
"""Check if Docker TerminusDB server is already running at http://127.0.0.1:6363"""
2324
try:
24-
response = requests.get("http://127.0.0.1:6363/api/ok", timeout=2)
25-
return response.status_code == 200
25+
requests.get("http://127.0.0.1:6363/api/ok", timeout=2)
26+
# Any HTTP response means server is running
27+
return True
2628
except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
2729
return False
2830

terminusdb_client/tests/integration_tests/test_conftest.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ def test_local_server_running_any_response(self, mock_get):
2323

2424
@patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
2525
def test_local_server_running_not_200(self, mock_get):
26-
"""Test local server detection returns False for non-200 status"""
26+
"""Test local server detection returns True for non-200 status (server is running)"""
2727
mock_response = Mock()
2828
mock_response.status_code = 401
2929
mock_get.return_value = mock_response
3030

31-
assert is_local_server_running() is False
31+
assert is_local_server_running() is True
3232

3333
@patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
3434
def test_local_server_not_running_connection_error(self, mock_get):
@@ -54,12 +54,12 @@ def test_docker_server_running_any_response(self, mock_get):
5454

5555
@patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
5656
def test_docker_server_running_not_200(self, mock_get):
57-
"""Test Docker server detection returns False for non-200 status"""
57+
"""Test Docker server detection returns True for non-200 status (server is running)"""
5858
mock_response = Mock()
5959
mock_response.status_code = 401
6060
mock_get.return_value = mock_response
6161

62-
assert is_docker_server_running() is False
62+
assert is_docker_server_running() is True
6363

6464
@patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
6565
def test_docker_server_not_running(self, mock_get):

terminusdb_client/woqlquery/woql_query.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2417,6 +2417,8 @@ def greater(self, left, right):
24172417
WOQLQuery object
24182418
query object that can be chained and/or execute
24192419
"""
2420+
if left and left == "args":
2421+
return ["left", "right"]
24202422
if left is None or right is None:
24212423
raise ValueError("Greater takes two parameters")
24222424
if self._cursor.get("@type"):

0 commit comments

Comments
 (0)