From 20b45bad3cb00c3a366f3adaf460edcb68a45d58 Mon Sep 17 00:00:00 2001
From: Bastien Orivel <borivel@mozilla.com>
Date: Fri, 17 Oct 2025 16:10:24 +0200
Subject: [PATCH] Make sure we return read only dicts from
 `links_and_reverse_links_dict`

Because we cache the return value, we don't want to be returning objects
with inner mutability as a consumer modifying those would end up
modifying the cached value, impacting all future accesses.
---
 src/taskgraph/graph.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/taskgraph/graph.py b/src/taskgraph/graph.py
index 9951c696f..d54d3b389 100644
--- a/src/taskgraph/graph.py
+++ b/src/taskgraph/graph.py
@@ -7,6 +7,8 @@
 import functools
 from dataclasses import dataclass
 
+from .util.readonlydict import ReadOnlyDict
+
 
 @dataclass(frozen=True)
 class _Graph:
@@ -81,7 +83,7 @@ def _visit(self, reverse):
         dependencies = reverse_links if reverse else forward_links
         dependents = forward_links if reverse else reverse_links
 
-        indegree = {node: len(dependencies[node]) for node in self.nodes}
+        indegree = {node: len(dependencies.get(node, ())) for node in self.nodes}
 
         queue = collections.deque(
             node for node, degree in indegree.items() if degree == 0
@@ -91,7 +93,7 @@ def _visit(self, reverse):
             node = queue.popleft()
             yield node
 
-            for dependent in dependents[node]:
+            for dependent in dependents.get(node, ()):
                 indegree[dependent] -= 1
                 if indegree[dependent] == 0:
                     queue.append(dependent)
@@ -120,13 +122,18 @@ def links_and_reverse_links_dict(self):
         Returns a (forward_links, reverse_links) tuple where forward_links maps
         each node to the set of nodes it links to, and reverse_links maps each
         node to the set of nodes linking to it.
+
+        Because the return value is cached, this function returns a pair of
+        `ReadOnlyDict` instead of defaultdicts like its `links_dict` and
+        `reverse_links_dict` counterparts to avoid consumers modifying the
+        cached value by mistake.
         """
         forward = collections.defaultdict(set)
         reverse = collections.defaultdict(set)
         for left, right, _ in self.edges:
             forward[left].add(right)
             reverse[right].add(left)
-        return (forward, reverse)
+        return (ReadOnlyDict(forward), ReadOnlyDict(reverse))
 
     def links_dict(self):
         """