Skip to content

Commit ef11bfc

Browse files
fix: updated default case and add kinds dir to graph config
1 parent 53e3c20 commit ef11bfc

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/taskgraph/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
Required("trust-domain"): str,
2929
Optional(
3030
"docker-image-kind",
31-
default="docker-image",
3231
description="Name of the docker image kind (default: docker-image)",
3332
): str,
3433
Required("task-priority"): optionally_keyed_by(
@@ -166,6 +165,10 @@ def taskcluster_yml(self):
166165
def docker_dir(self):
167166
return os.path.join(self.root_dir, "docker")
168167

168+
@property
169+
def kinds_dir(self):
170+
return os.path.join(self.root_dir, "kinds")
171+
169172

170173
def validate_graph_config(config):
171174
validate_schema(graph_config_schema, config, "Invalid graph configuration:")

src/taskgraph/util/docker.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,8 @@ def image_paths(graph_config):
210210
"""Return a map of image name to paths containing their Dockerfile."""
211211

212212
config = load_yaml(
213-
graph_config.root_dir,
214-
"kinds",
215-
graph_config["docker-image-kind"],
213+
graph_config.kinds_dir,
214+
graph_config.get("docker-image-kind", "docker-image"),
216215
"kind.yml",
217216
)
218217

taskcluster/config.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ index:
1414

1515
task-priority: low
1616

17-
docker-image-kind: docker-image
18-
1917
taskgraph:
2018
register: self_taskgraph:register
2119
decision-parameters: 'self_taskgraph.custom_parameters:decision_parameters'

0 commit comments

Comments
 (0)