Skip to content

Commit baa0628

Browse files
committed
fix: Add False as option in from-deps set-name config
1 parent 9b1b869 commit baa0628

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

src/taskgraph/transforms/from_deps.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
),
4949
): Any(
5050
None,
51+
False,
5152
*SET_NAME_MAP,
5253
{Any(*SET_NAME_MAP): object},
5354
),

test/test_transforms_from_deps.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,12 @@ def assert_dont_set_name(tasks):
9191
assert tasks[0]["name"] == "a-special-name"
9292

9393

94+
def assert_dont_set_name_false(tasks):
95+
handle_exception(tasks)
96+
assert len(tasks) == 1
97+
assert tasks[0]["name"] == "a-special-name"
98+
99+
94100
def assert_set_name_strip_kind(tasks):
95101
handle_exception(tasks)
96102
assert len(tasks) == 2
@@ -187,6 +193,21 @@ def assert_group_by_all_with_fetch(tasks):
187193
None,
188194
id="dont_set_name",
189195
),
196+
pytest.param(
197+
# task
198+
{
199+
"name": "a-special-name",
200+
"from-deps": {
201+
"group-by": "all",
202+
"set-name": False,
203+
},
204+
},
205+
# kind config
206+
None,
207+
# deps
208+
None,
209+
id="dont_set_name_false",
210+
),
190211
pytest.param(
191212
# task
192213
{

0 commit comments

Comments
 (0)